From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: dhowells@redhat.com, Michael Albinus <michael.albinus@gmx.de>,
64439@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: bug#64439: 28.2; auto-fill-mode gets turned on all over the place
Date: Mon, 10 Jul 2023 16:53:41 -0700 [thread overview]
Message-ID: <2cc838cc-058e-7275-9b84-fb872b65fa24@gmail.com> (raw)
In-Reply-To: <f1919eb5-552c-ca50-9ba2-5518b8830cd1@gmail.com>
On 7/10/2023 2:54 PM, Jim Porter wrote:
> Interestingly, I can't reproduce this on Emacs 30 (latest master), but I
> *can* on Emacs 28.2 and the latest rev on the Emacs 29 branch. I haven't
> dug any further yet to see which commit could have changed this though.
... and it looks like you're the one who fixed this, Stefan! Should this
get backported into the emacs-29 branch? It's a one-line fix, but I'm
not sure if a fix to "src/eval.c" is too invasive for the release branch...
5223762e02ac84eee984cd1f7a17865766cdad9a is the first fixed commit
commit 5223762e02ac84eee984cd1f7a17865766cdad9a
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Sun Apr 2 17:45:58 2023 -0400
src/eval.c: Fix bug#62419
Yup, almost 40 years after ELisp first combined them, buffer-local
and let bindings still don't work quite right :-(
The "automatically buffer-local if set" semantics should follow the
principle that it becomes buffer-local iff the var's current binding
refers to the top-level/global/non-let binding.
* src/eval.c (let_shadows_buffer_binding_p): Disregard non-global
let-bindings.
* test/src/eval-tests.el (eval-test--bug62419): New test.
next prev parent reply other threads:[~2023-07-10 23:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:55 bug#64439: 28.2; auto-fill-mode gets turned on all over the place David Howells
2023-07-03 16:15 ` Eli Zaretskii
2023-07-03 17:48 ` David Howells
2023-07-03 18:29 ` Eli Zaretskii
2023-07-09 5:57 ` Jim Porter
2023-07-09 6:45 ` Eli Zaretskii
2023-07-09 18:00 ` Jim Porter
2023-07-10 11:59 ` Eli Zaretskii
2023-07-10 16:00 ` Jim Porter
2023-07-10 17:28 ` Michael Albinus
2023-07-10 17:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-10 20:57 ` Jim Porter
2023-07-10 21:54 ` Jim Porter
2023-07-10 23:53 ` Jim Porter [this message]
2023-07-11 11:31 ` Eli Zaretskii
2023-07-11 16:07 ` Jim Porter
2023-07-11 18:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-12 2:23 ` Jim Porter
2023-07-12 12:13 ` Eli Zaretskii
2023-07-03 18:14 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cc838cc-058e-7275-9b84-fb872b65fa24@gmail.com \
--to=jporterbugs@gmail.com \
--cc=64439@debbugs.gnu.org \
--cc=dhowells@redhat.com \
--cc=eliz@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).