From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#64439: 28.2; auto-fill-mode gets turned on all over the place Date: Mon, 10 Jul 2023 16:53:41 -0700 Message-ID: <2cc838cc-058e-7275-9b84-fb872b65fa24@gmail.com> References: <83h6qlm0oc.fsf@gnu.org> <1034974.1688399705@warthog.procyon.org.uk> <1211099.1688406521@warthog.procyon.org.uk> <837crgn90u.fsf@gnu.org> <11d9848d-5a70-c1e5-cbc8-e00341889398@gmail.com> <83edlhbn1y.fsf@gnu.org> <83zg447za9.fsf@gnu.org> <6e26e6cf-5784-48fa-4822-5657e8e2db60@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dhowells@redhat.com, Michael Albinus , 64439@debbugs.gnu.org, Noam Postavsky To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 11 01:54:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJ0ht-000ADC-No for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jul 2023 01:54:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJ0hg-0005am-Rd; Mon, 10 Jul 2023 19:54:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJ0hf-0005a7-4C for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 19:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJ0he-0001GY-T9 for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 19:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJ0he-0007Va-HK for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 19:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jul 2023 23:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64439 X-GNU-PR-Package: emacs Original-Received: via spool by 64439-submit@debbugs.gnu.org id=B64439.168903323228846 (code B ref 64439); Mon, 10 Jul 2023 23:54:02 +0000 Original-Received: (at 64439) by debbugs.gnu.org; 10 Jul 2023 23:53:52 +0000 Original-Received: from localhost ([127.0.0.1]:49408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJ0hT-0007VC-T2 for submit@debbugs.gnu.org; Mon, 10 Jul 2023 19:53:52 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:50352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJ0hR-0007Uz-7S for 64439@debbugs.gnu.org; Mon, 10 Jul 2023 19:53:50 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-55b5a3915f5so3483325a12.0 for <64439@debbugs.gnu.org>; Mon, 10 Jul 2023 16:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689033223; x=1691625223; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=NOtanIt8XX3b2oYLJ0FUo6ylLfu1MgEu6o833C/5bIY=; b=po9t+pFSc/MRW0vvsgFuc3m5jd/jpYkFCcv68IzCLnJXdKo/Ahd57J7sFA1J5HQuSz z1TT+n26Cx0/PuNmMFFHn7dEorPVNYKnV5NiM4erOm/MOsryQ4WYxKJ0mbUyw578lxbq 2dy1r69luAHiV92btxpxBjufWIotvmbwnRSVWtCdgPOhNkLBqKMl9vPv6WXX5MZL3BmZ uWihT2LFbDb01f2BzEqeydDDusubvwIp/wooxiQxyfXp0+rO5oHCyWjPZMxUcjpuWYwV b4HSaDICoaZwP5ewyTeMWg6qgadfqIBS2CY8CaXuz1glvdeXf3gW5j4sC8jEixDGDuve 5MJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689033223; x=1691625223; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NOtanIt8XX3b2oYLJ0FUo6ylLfu1MgEu6o833C/5bIY=; b=GoJzcqfiLoi60zIvPsNi6s1faUFvEVSe+ZQAwfn7cuvCS9+YSZ3c5jUKOb7gtgKr1m mz2BJ/KUjGDL3JE4P+2qPFzfUexCbuaKQqIXJi9iX9j65vMTIbvKpGqK94uiYtuhkqy5 eOMsgn90lVTvW6sVz+4cw/AfP+pmT7X0elFFhUZmybXSWowxk6GpTUdWiBROuCqKbP9z +JqIYeRSUcOAEqaZQ665TWm533sDMFBr3H8e7HTNzgR3V8aUwxN8xHE6YaDznp8///wD q+k83bDE8qP9zzm5xcL44gT1ORjH0HpodEGT/TSQNUekA6+ptBuLMZS7LcGTuiofdk/k YHrA== X-Gm-Message-State: ABy/qLaC1APHUsEIlP2xM58G3KuTlBjTdX/mjU3LXLikgdc1y6m3P90N woJxorzvNu4Ly5oBhly3Zu8= X-Google-Smtp-Source: APBJJlEqeM9+BLtOvgUsfjCICu/bNazpWdlq/dhGC+dQYzdOPWs99076I3Q3At5+2AOkw/oBwPeelw== X-Received: by 2002:a17:90a:df02:b0:25c:571:44bc with SMTP id gp2-20020a17090adf0200b0025c057144bcmr11801872pjb.28.1689033223105; Mon, 10 Jul 2023 16:53:43 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id bg4-20020a1709028e8400b001b53be3d942sm432410plb.232.2023.07.10.16.53.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 16:53:42 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264910 Archived-At: On 7/10/2023 2:54 PM, Jim Porter wrote: > Interestingly, I can't reproduce this on Emacs 30 (latest master), but I > *can* on Emacs 28.2 and the latest rev on the Emacs 29 branch. I haven't > dug any further yet to see which commit could have changed this though. ... and it looks like you're the one who fixed this, Stefan! Should this get backported into the emacs-29 branch? It's a one-line fix, but I'm not sure if a fix to "src/eval.c" is too invasive for the release branch... 5223762e02ac84eee984cd1f7a17865766cdad9a is the first fixed commit commit 5223762e02ac84eee984cd1f7a17865766cdad9a Author: Stefan Monnier Date: Sun Apr 2 17:45:58 2023 -0400 src/eval.c: Fix bug#62419 Yup, almost 40 years after ELisp first combined them, buffer-local and let bindings still don't work quite right :-( The "automatically buffer-local if set" semantics should follow the principle that it becomes buffer-local iff the var's current binding refers to the top-level/global/non-let binding. * src/eval.c (let_shadows_buffer_binding_p): Disregard non-global let-bindings. * test/src/eval-tests.el (eval-test--bug62419): New test.