From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47574@debbugs.gnu.org
Subject: bug#47574: 'match' face is too bright
Date: Sat, 3 Apr 2021 21:26:15 +0300 [thread overview]
Message-ID: <2b966549-1426-f748-c2b6-ff390d911ea0@yandex.ru> (raw)
In-Reply-To: <83wntjeus0.fsf@gnu.org>
On 03.04.2021 09:39, Eli Zaretskii wrote:
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> Date: Sat, 3 Apr 2021 02:42:43 +0300
>>
>> Split off from the discussion in bug#47012.
>>
>> I think the current "yellow1" is too bright and in-your-face.
>>
>> It handles its goal (having the matched substrings noticed) admirably,
>> but perhaps too well, because we normally don't want to reach each
>> match, but rather the contents of the line around it. So I think it's
>> not productive putting so much visual attention on it.
>
> If someone wants to see the lines without the match standing out, they
> can customize list-matching-lines-face to nil. So this use case is
> already covered.
I'm talking rather about the other uses of the 'match' face: the Grep
buffer, the Occur buffer, and the uses of the xref-match face (which
inherits from 'match' now) inside the Xref buffer (xref-find-references
or project-find-regexp).
My argument is that it's the dominant use case, so it's worth trying to
improve the default configuration.
> FTR, I do want to see the match itself, so this face does its job for
> me very well.
Sure, I do too. From my experience, though, it's visible enough with any
of the proposed colors. Even 'lemon chiffon', though I agree the result
is fairly subtle.
>> Juri suggested #ffff88, and it seems good to me. Both readable and
>> noticeable, yet not too bright.
>>
>> My original suggestions were "lemon chiffon" (seems ideally subdued to
>> me, but it would be a drastic change), "khaki1" or "light goldenrod".
>
> If we change the face's colors, we should make sure the new colors
> look well on both light and dark backgrounds.
My proposal is specifically for the light background (the min-colors 88
case), with the default theme as the baseline.
Looking at the dark background color (and trying it with a couple of
dark themes), I think it could use some toning down as well from
RoyalBlue3 to RoyalBlue4, but others who prefer dark backgrounds can
probably tell better.
next prev parent reply other threads:[~2021-04-03 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 23:42 bug#47574: 'match' face is too bright Dmitry Gutov
2021-04-03 0:13 ` bug#47574: [External] : " Drew Adams
2021-04-03 6:39 ` Eli Zaretskii
2021-04-03 18:26 ` Dmitry Gutov [this message]
2021-04-14 14:55 ` Stefan Kangas
2021-04-15 13:57 ` Dmitry Gutov
2021-04-15 14:38 ` Eli Zaretskii
2021-04-18 10:16 ` Stefan Kangas
2021-04-22 0:13 ` Dmitry Gutov
2021-05-06 11:07 ` Lars Ingebrigtsen
2021-04-15 14:56 ` bug#47574: [External] : " Drew Adams
2021-04-15 15:43 ` Dmitry Gutov
2021-04-15 16:04 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b966549-1426-f748-c2b6-ff390d911ea0@yandex.ru \
--to=dgutov@yandex.ru \
--cc=47574@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).