From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47574: 'match' face is too bright Date: Sat, 3 Apr 2021 21:26:15 +0300 Message-ID: <2b966549-1426-f748-c2b6-ff390d911ea0@yandex.ru> References: <83wntjeus0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21065"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: 47574@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 03 20:27:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSkzi-0005O7-He for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Apr 2021 20:27:38 +0200 Original-Received: from localhost ([::1]:47458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSkzh-0005s4-6V for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Apr 2021 14:27:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSkz9-0005rv-IW for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2021 14:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSkz7-0000hH-W2 for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2021 14:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSkz7-0007hD-SI for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2021 14:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Apr 2021 18:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47574 X-GNU-PR-Package: emacs Original-Received: via spool by 47574-submit@debbugs.gnu.org id=B47574.161747438629541 (code B ref 47574); Sat, 03 Apr 2021 18:27:01 +0000 Original-Received: (at 47574) by debbugs.gnu.org; 3 Apr 2021 18:26:26 +0000 Original-Received: from localhost ([127.0.0.1]:34417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSkyY-0007gP-3N for submit@debbugs.gnu.org; Sat, 03 Apr 2021 14:26:26 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:43930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSkyV-0007g9-MU for 47574@debbugs.gnu.org; Sat, 03 Apr 2021 14:26:24 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id u5-20020a7bcb050000b029010e9316b9d5so3748650wmj.2 for <47574@debbugs.gnu.org>; Sat, 03 Apr 2021 11:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nGVqyP5iWgyxVm76NM1vM7mTKb5gPiKf20xMywsrIPE=; b=mop8BaDd2QkIUF0pq/P01T0mWN+kWRx+pDEhhSo5kJ8wN59pF3it2Md1VYaOTjJFqC mMNzw3Wf4iVGxIqISX0lUb1TSxYttukanBDui6M0MspsR1JNX1XTSLRsZHFfNc75RDET haj/kK0xnMRcEbDJjLeOw1+U/9gyqbnGBzeZ2IRadepV+IGpVDEFw40DhOgoZILQk171 7jf6cPW0KwH9wK6c3ttc8tZYZE/ZhnVQEZ8nOzwC9An9Dm5W35eas+9uDBAI8jGkYReh 9GtaIAqu0heEYgZ/lCzomYa84o7pYPD+QJtpCElijtha/aLOu5/LMGBFcfB8NwR7jFrB hWLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nGVqyP5iWgyxVm76NM1vM7mTKb5gPiKf20xMywsrIPE=; b=MJlbgpCLUFlECNPZWN+Skmg6/MQP1reO4p1affm/RuTmr9Rf9Qb5cKalX7JBWaDzYU uv3n4d4bUNAHognrFAIplp3HdqXMQk2NIWHLz0ozm9I+Dpmo2P+NHKjjC6cZBz7aSx1V U18DZWZInP56AvVy55XZwgJg17Outs6WgUkRycnYW8rlAXwUoLUYjDLcHmb462Qn5bvw rQzTKEU6AsvJJqtOCNEeKwyqNKp5A7bTkRpqSAILwbWU68a3Pw6E6SRO6VJp9JS2QaOU TUDOMN1j6WQXXGQYpn+BKOhUTLW7tUBDX1VGHlpj8akTeIRUIliJglSXhHf8VxHEw7pR suNw== X-Gm-Message-State: AOAM533K6QkEuDlfZn6EFCgz7QrkblrZcPaAigwwnu3KWrJjujGflqBc eWi0h5LU66HTDCiQvCMKpUhQaJ3ehdY= X-Google-Smtp-Source: ABdhPJycunPxhJVeBwMrsednBx/dpeqNV/yOCIOY4Z540sHGnkAJnYRbSzdWQ4u/kyRin9rb0F2tnQ== X-Received: by 2002:a1c:7209:: with SMTP id n9mr18411287wmc.132.1617474377612; Sat, 03 Apr 2021 11:26:17 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u8sm20856302wrr.42.2021.04.03.11.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Apr 2021 11:26:17 -0700 (PDT) In-Reply-To: <83wntjeus0.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203496 Archived-At: On 03.04.2021 09:39, Eli Zaretskii wrote: >> From: Dmitry Gutov >> Date: Sat, 3 Apr 2021 02:42:43 +0300 >> >> Split off from the discussion in bug#47012. >> >> I think the current "yellow1" is too bright and in-your-face. >> >> It handles its goal (having the matched substrings noticed) admirably, >> but perhaps too well, because we normally don't want to reach each >> match, but rather the contents of the line around it. So I think it's >> not productive putting so much visual attention on it. > > If someone wants to see the lines without the match standing out, they > can customize list-matching-lines-face to nil. So this use case is > already covered. I'm talking rather about the other uses of the 'match' face: the Grep buffer, the Occur buffer, and the uses of the xref-match face (which inherits from 'match' now) inside the Xref buffer (xref-find-references or project-find-regexp). My argument is that it's the dominant use case, so it's worth trying to improve the default configuration. > FTR, I do want to see the match itself, so this face does its job for > me very well. Sure, I do too. From my experience, though, it's visible enough with any of the proposed colors. Even 'lemon chiffon', though I agree the result is fairly subtle. >> Juri suggested #ffff88, and it seems good to me. Both readable and >> noticeable, yet not too bright. >> >> My original suggestions were "lemon chiffon" (seems ideally subdued to >> me, but it would be a drastic change), "khaki1" or "light goldenrod". > > If we change the face's colors, we should make sure the new colors > look well on both light and dark backgrounds. My proposal is specifically for the light background (the min-colors 88 case), with the default theme as the baseline. Looking at the dark background color (and trying it with a couple of dark themes), I think it could use some toning down as well from RoyalBlue3 to RoyalBlue4, but others who prefer dark backgrounds can probably tell better.