From: Jim Porter <jporterbugs@gmail.com>
To: Antero Mejr <antero@mailbox.org>
Cc: eliz@gnu.org, 62426@debbugs.gnu.org,
Sean Whitton <spwhitton@spwhitton.name>
Subject: bug#62426: [PATCH] eshell: Add 'rgrep' builtin.
Date: Mon, 10 Apr 2023 21:01:49 -0700 [thread overview]
Message-ID: <2a8bf589-ad5a-151b-096c-ab86f90c5c4e@gmail.com> (raw)
In-Reply-To: <87fs97np3v.fsf@mailbox.org>
On 4/10/2023 7:12 PM, Antero Mejr via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
> Jim Porter <jporterbugs@gmail.com> writes:
>
>> I just see one issue with the patch: the NEWS entry and docstring are a bit
>> misleading. I know these are just copying from the existing Eshell functions,
>> but this isn't really accurate: "Use Emacs grep facility instead of calling
>> external rgrep." It *always* calls the external rgrep; it's just that sometimes
>> the output goes into a compilation buffer.
>
> I don't think that's always the case. In the "eshell-grep" function it
> checks if external grep is available, and if not then it uses a slow
> elisp-only implementation. Then it checks to see if the output is being
> redirected, and so on.
>
> IMO that entire process constitutes the "emacs grep facility" as
> described in the docstring.
Good point. There's probably a way to indicate that more clearly, but
I'll think it over. It shouldn't hold up merging this. Therefore, I've
merged your patch as ebac67129e8.
This change is pretty close to the limit for changes that you can make
without assigning copyright to the FSF (15 lines). I'm not sure if
you've filled out the paperwork (I don't think I have the permissions to
check directly), but if not, do you want to fill it out so you can make
more changes to Emacs in the future? I think Eli (CCed) can get you
started if so.
next prev parent reply other threads:[~2023-04-11 4:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 21:02 bug#62426: [PATCH] eshell: Add 'rgrep' builtin Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-25 0:04 ` Jim Porter
2023-03-25 17:22 ` Sean Whitton
2023-03-25 19:07 ` Jim Porter
2023-03-30 21:19 ` Sean Whitton
2023-03-31 0:14 ` Jim Porter
2023-04-09 1:55 ` Jim Porter
2023-04-11 2:12 ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-11 4:01 ` Jim Porter [this message]
2023-06-03 1:41 ` bug#62426: (no subject) Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a8bf589-ad5a-151b-096c-ab86f90c5c4e@gmail.com \
--to=jporterbugs@gmail.com \
--cc=62426@debbugs.gnu.org \
--cc=antero@mailbox.org \
--cc=eliz@gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).