From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#62426: [PATCH] eshell: Add 'rgrep' builtin. Date: Mon, 10 Apr 2023 21:01:49 -0700 Message-ID: <2a8bf589-ad5a-151b-096c-ab86f90c5c4e@gmail.com> References: <87jzz5eucl.fsf@mailbox.org> <87355syce8.fsf@athena.silentflame.com> <87fs97np3v.fsf@mailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19128"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, 62426@debbugs.gnu.org, Sean Whitton To: Antero Mejr Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 11 06:02:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm5DC-0004mG-C6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Apr 2023 06:02:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pm5Cq-00010U-7X; Tue, 11 Apr 2023 00:02:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm5Co-0000zv-J2 for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 00:02:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pm5Ck-00061k-Pb for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 00:02:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pm5Ck-0002rN-5T for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 00:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Apr 2023 04:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62426-submit@debbugs.gnu.org id=B62426.168118572110986 (code B ref 62426); Tue, 11 Apr 2023 04:02:02 +0000 Original-Received: (at 62426) by debbugs.gnu.org; 11 Apr 2023 04:02:01 +0000 Original-Received: from localhost ([127.0.0.1]:36282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm5Ci-0002r7-Oo for submit@debbugs.gnu.org; Tue, 11 Apr 2023 00:02:01 -0400 Original-Received: from mail-pl1-f180.google.com ([209.85.214.180]:34441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm5Ce-0002qt-HY for 62426@debbugs.gnu.org; Tue, 11 Apr 2023 00:01:58 -0400 Original-Received: by mail-pl1-f180.google.com with SMTP id h24so6771968plr.1 for <62426@debbugs.gnu.org>; Mon, 10 Apr 2023 21:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681185710; x=1683777710; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=CUO2pyDT6OlS4H+mYTGNwOSENqnNHsCoYK2YS6HJ820=; b=RXf/Hka54rs6tkAx0VMC+tiEGaUaTTufSL0ewlXVm3XDo9qnMM4kWO2EkLr1fwKyyh TEQITRXiW5ugc0rwJ7UXiW1RLVr1dWLvObi0X1mOc/qXdGfQuTqBy3C0kwZpRxRoq9V8 fAmrewbWiCRAiOW15KEvpSVz/REz9uBt39AfUJY6C5nr8i1CIPc3SpIbhwkjFsoM4tfm whmK3djcU5SKCvNwZT63fDco+qI5X/p0qxqknIYOTKoTiGX9Abm9kpC/sznO3oHcc8Th bRFQisiFqGBBwqpJezAMvDlcffTqPVEccSsCpmcipQPsvSd8nZKe6orA+DfFfDTIuIHj B7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681185710; x=1683777710; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CUO2pyDT6OlS4H+mYTGNwOSENqnNHsCoYK2YS6HJ820=; b=OxiTr+jM0lpem+KwRQ/W7onVR8D7FTcS1Czb8u4WGhjTJJ3t394A4+uWYccFkhfjc/ QSRKREpo/b1h6cm9Ru2xgTNK1eJkXVImESq+Ci/sAAWSJ0UnNo55R3xhMvoO+Nu24tQL Ow0XxOQquFkwYK6jPsoQC8oOikqeBL3nlMbTy4czNFcoAhD4YIykTrs9Oze7ufrN/7EK IxE/AW2fUc1Rst+t2kQGtClUTWAfSN5LtyR4ExoXXI61U6MlIAIrXrhcyoRnMLF02X/z ojhdJT7h0gERxv5jh98L6cPQTC8AcDRZhVLjAkcaNpssToTnzvDGloMz9eS8LRLXAi2f dKxg== X-Gm-Message-State: AAQBX9dnOjr6z/LIk9NW4ty/U3oKbKtil2ChXo6xZ4ynAmoxLSHsWisz 93eENw/7/nBjSL3N/6tq8sw= X-Google-Smtp-Source: AKy350acCjOfemekhuKVMUOZ/JQGoJz+odv1xvWBBYu1ekMplyapGadKFryLWeYxil8IzJrYeyj6uQ== X-Received: by 2002:a17:903:1250:b0:1a5:a1b:bbd8 with SMTP id u16-20020a170903125000b001a50a1bbbd8mr18314802plh.45.1681185710010; Mon, 10 Apr 2023 21:01:50 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id f22-20020a63f756000000b005142206430fsm7619119pgk.36.2023.04.10.21.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 21:01:49 -0700 (PDT) Content-Language: en-US In-Reply-To: <87fs97np3v.fsf@mailbox.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259618 Archived-At: On 4/10/2023 7:12 PM, Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Jim Porter writes: > >> I just see one issue with the patch: the NEWS entry and docstring are a bit >> misleading. I know these are just copying from the existing Eshell functions, >> but this isn't really accurate: "Use Emacs grep facility instead of calling >> external rgrep." It *always* calls the external rgrep; it's just that sometimes >> the output goes into a compilation buffer. > > I don't think that's always the case. In the "eshell-grep" function it > checks if external grep is available, and if not then it uses a slow > elisp-only implementation. Then it checks to see if the output is being > redirected, and so on. > > IMO that entire process constitutes the "emacs grep facility" as > described in the docstring. Good point. There's probably a way to indicate that more clearly, but I'll think it over. It shouldn't hold up merging this. Therefore, I've merged your patch as ebac67129e8. This change is pretty close to the limit for changes that you can make without assigning copyright to the FSF (15 lines). I'm not sure if you've filled out the paperwork (I don't think I have the permissions to check directly), but if not, do you want to fill it out so you can make more changes to Emacs in the future? I think Eli (CCed) can get you started if so.