bug#885: dired deleting a file can delete the entire directory

bug#885: dired deleting a file can delete the entire directory

[a a]

If you create a file whose filename is a double quotation mark and try to delete it in dired-mode, and if you say yes to the questions, the entire directory is deleted.

out@themovies:~% mkdir test
out@themovies:~% cd test
out@themovies:~/test% touch \"\"

Now in emacs dired-mode remove the file ""

  /home/out/test:
  total used in directory 24 available 263498424
  drwxr-xr-x   2 out out  4096 2008-09-04 08:28 .
  drwxr-xr-x 133 out out 20480 2008-09-04 08:28 ..
D -rw-r--r--   1 out out     0 2008-09-04 08:28 ""

Delete  (yes or no) yes
Recursive delete of ? (yes or no) yes
Killed dired buffer of , too (y or n) y

Instead of just removing the file, the entire directory /home/out/test is deleted.

The machine is running Ubuntu 7.10 (Gutsy), the version of emacs is 23.0.60.1, from
Alexandre Vassalotti's deb package with xft support:

deb http://ppa.launchpad.net/avassalotti/ubuntu gutsy main

% emacs-snapshot-gtk --version
GNU Emacs 23.0.60.1
Copyright (C) 2008 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

apt-cache policy emacs-snapshot
emacs-snapshot:
  Installed: 1:20080228-2~gutsy
  Candidate: 1:20080228-2~gutsy
  Version table:
 *** 1:20080228-2~gutsy 0
        500 http://ppa.launchpad.net gutsy/main Packages
        100 /var/lib/dpkg/status
     1:20070805-1ubuntu1 0
        500 http://archive.ubuntu.com gutsy/universe Packages
        500 http://us.archive.ubuntu.com gutsy/universe Packages



      

bug#885: marked as done (dired deleting a file can delete the entire directory)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]


Your message dated Fri, 05 Sep 2008 17:19:33 -0400
with message-id <87prni1eai.fsf@cyd.mit.edu>
and subject line Re: dired deleting a file can delete the entire directory
has caused the Emacs bug report #885,
regarding dired deleting a file can delete the entire directory
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
885: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=885
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3962 bytes --]

From: a a <driabslg@yahoo.com>
To: bug-gnu-emacs@gnu.org
Subject: dired deleting a file can delete the entire directory
Date: Thu, 4 Sep 2008 05:50:14 -0700 (PDT)
Message-ID: <29958.20075.qm@web39602.mail.mud.yahoo.com>

If you create a file whose filename is a double quotation mark and try to delete it in dired-mode, and if you say yes to the questions, the entire directory is deleted.

out@themovies:~% mkdir test
out@themovies:~% cd test
out@themovies:~/test% touch \"\"

Now in emacs dired-mode remove the file ""

  /home/out/test:
  total used in directory 24 available 263498424
  drwxr-xr-x   2 out out  4096 2008-09-04 08:28 .
  drwxr-xr-x 133 out out 20480 2008-09-04 08:28 ..
D -rw-r--r--   1 out out     0 2008-09-04 08:28 ""

Delete  (yes or no) yes
Recursive delete of ? (yes or no) yes
Killed dired buffer of , too (y or n) y

Instead of just removing the file, the entire directory /home/out/test is deleted.

The machine is running Ubuntu 7.10 (Gutsy), the version of emacs is 23.0.60.1, from
Alexandre Vassalotti's deb package with xft support:

deb http://ppa.launchpad.net/avassalotti/ubuntu gutsy main

% emacs-snapshot-gtk --version
GNU Emacs 23.0.60.1
Copyright (C) 2008 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

apt-cache policy emacs-snapshot
emacs-snapshot:
  Installed: 1:20080228-2~gutsy
  Candidate: 1:20080228-2~gutsy
  Version table:
 *** 1:20080228-2~gutsy 0
        500 http://ppa.launchpad.net gutsy/main Packages
        100 /var/lib/dpkg/status
     1:20070805-1ubuntu1 0
        500 http://archive.ubuntu.com gutsy/universe Packages
        500 http://us.archive.ubuntu.com gutsy/universe Packages



      




[-- Attachment #3: Type: message/rfc822, Size: 1154 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: a a <driabslg@yahoo.com>
Cc: 885-done@emacsbugs.donarmstrong.com
Subject: Re: dired deleting a file can delete the entire directory
Date: Fri, 05 Sep 2008 17:19:33 -0400
Message-ID: <87prni1eai.fsf@cyd.mit.edu>

> If you create a file whose filename is a double quotation mark and try
> to delete it in dired-mode, and if you say yes to the questions, the
> entire directory is deleted.

I've checked in a fix.  Thanks.