unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: "Simen Heggestøyl" <simenheg@runbox.com>
Cc: 55315@debbugs.gnu.org
Subject: bug#55315: [elpa/csv-mode] [PATCH] CSV separator guessing
Date: Mon, 9 May 2022 11:37:41 +0200	[thread overview]
Message-ID: <288326F0-A0EA-4CCE-B1E7-C8184255B046@acm.org> (raw)
In-Reply-To: <87mtfryg73.fsf@simenheg@gmail.com>

8 maj 2022 kl. 21.31 skrev Simen Heggestøyl <simenheg@runbox.com>:

> Am I right in thinking that the use of
> `regexp-quote' in the `csv-set-separator' case gives the right result?

Yes, I think so. `csv-set-separator` should probably escape the character in `csv--skip-chars`, however:

  (setq-local csv--skip-chars (format "^\n%c" sep))

should be

  (setq-local csv--skip-chars (format "^\n\\%c" sep))

I'm not sure if a separator can be chosen that needs escaping here but better be safe; who knows how the code will be used.






  parent reply	other threads:[~2022-05-09  9:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h760jeq7.fsf@simenheg@gmail.com>
2022-05-08 17:56 ` bug#55315: [elpa/csv-mode] [PATCH] CSV separator guessing Mattias Engdegård
2022-05-08 19:31   ` Simen Heggestøyl
     [not found]   ` <87mtfryg73.fsf@simenheg@gmail.com>
2022-05-09  9:37     ` Mattias Engdegård [this message]
2022-05-09 11:03       ` Simen Heggestøyl
2022-05-09 11:28         ` Mattias Engdegård
2022-05-12 19:59           ` Simen Heggestøyl
2022-05-08 14:12 Simen Heggestøyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=288326F0-A0EA-4CCE-B1E7-C8184255B046@acm.org \
    --to=mattiase@acm.org \
    --cc=55315@debbugs.gnu.org \
    --cc=simenheg@runbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).