From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#55315: [elpa/csv-mode] [PATCH] CSV separator guessing Date: Mon, 9 May 2022 11:37:41 +0200 Message-ID: <288326F0-A0EA-4CCE-B1E7-C8184255B046@acm.org> References: <07E204D4-5FE4-4122-BB82-EBB2107C09E8@acm.org> <87mtfryg73.fsf@simenheg@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3190"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55315@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 11:51:49 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no03R-0000bO-0z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 11:51:49 +0200 Original-Received: from localhost ([::1]:59412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no03Q-0007Jn-3B for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 05:51:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnzq7-0002T0-MK for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:38:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnzq5-0002eY-W6 for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nnzq5-0002iW-TB for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 09:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55315-submit@debbugs.gnu.org id=B55315.165208907310429 (code B ref 55315); Mon, 09 May 2022 09:38:01 +0000 Original-Received: (at 55315) by debbugs.gnu.org; 9 May 2022 09:37:53 +0000 Original-Received: from localhost ([127.0.0.1]:56113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnzpx-0002i9-9Q for submit@debbugs.gnu.org; Mon, 09 May 2022 05:37:53 -0400 Original-Received: from mail1450c50.megamailservers.eu ([91.136.14.50]:60228 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnzpv-0002hu-Cw for 55315@debbugs.gnu.org; Mon, 09 May 2022 05:37:52 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1652089064; bh=umwvtGEehlk18QFvM6gi5PQNkCzLdAOnqmcGWgpgu/s=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Q5nG37bvg20/gBs87EISkUkYxEdHi9xqFLg+wQsdtebJV3gh2XVLzFkWWGNXebdzX 7HQYOzuelxvyckvLCp+57iMO5QuEsMr64+FFGSFM7O/3tGwdmcWPgdKcZNH+hmJolP omIM757UEgQ8w5CGssuLwaHbw2cePtx+JiPJ4lvk= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2499bgZW027781; Mon, 9 May 2022 09:37:43 +0000 In-Reply-To: <87mtfryg73.fsf@simenheg@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F2A.6278E0E8.002E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231702 Archived-At: 8 maj 2022 kl. 21.31 skrev Simen Heggest=C3=B8yl : > Am I right in thinking that the use of > `regexp-quote' in the `csv-set-separator' case gives the right result? Yes, I think so. `csv-set-separator` should probably escape the = character in `csv--skip-chars`, however: (setq-local csv--skip-chars (format "^\n%c" sep)) should be (setq-local csv--skip-chars (format "^\n\\%c" sep)) I'm not sure if a separator can be chosen that needs escaping here but = better be safe; who knows how the code will be used.