* bug#19059: [FIX INCLUDED] desktop-read re-enables desktop autosave when it shouldn't
@ 2014-11-15 6:57 Kelly Dean
0 siblings, 0 replies; only message in thread
From: Kelly Dean @ 2014-11-15 6:57 UTC (permalink / raw)
To: 19059
With emacs 24.4, run emacs -Q, then do
(desktop-save-mode 1)
Notice that window-configuration-change-hook now (correctly) contains desktop-auto-save-set-timer, since desktop-save-mode defaults to enabling desktop autosave. Now do
(desktop-auto-save-disable)
Notice that desktop-auto-save-set-timer is (correctly) removed from the hook. Now do
(desktop-save "~/.emacs.d")
(desktop-read)
Notice that desktop-auto-save-set-timer is added back to the hook, which is a bug since you didn't ask for desktop autosave to be re-enabled.
This bug wasn't in 24.3, because 24.3 didn't have the desktop autosave feature.
The bug is in desktop.el of the 24.4 release, line 1191, which unconditionally calls desktop-auto-save-enable. The fix is to change that to conditionally call desktop-auto-save-enable, if desktop autosave was enabled (indicated by presence of desktop-auto-save-set-timer in the hook) prior to being disabled by the call to desktop-auto-save-disable on line 1138. Patch excluded, per request.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-11-15 6:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-15 6:57 bug#19059: [FIX INCLUDED] desktop-read re-enables desktop autosave when it shouldn't Kelly Dean
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).