bug#47975: 28.0.50; Project prefixed buffer name

bug#47975: 28.0.50; Project prefixed buffer name

[Juri Linkov]

[-- Attachment #1: Type: text/plain, Size: 56 bytes --]

It seems the commit 08fab316a1 calls for more changes:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: project-prefixed-buffer-name.patch --]
[-- Type: text/x-diff, Size: 1661 bytes --]

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 5996a76488..914d7ce9e4 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -918,10 +918,7 @@ project-shell
 if one already exists."
   (interactive)
   (let* ((default-directory (project-root (project-current t)))
-         (default-project-shell-name
-           (concat "*" (file-name-nondirectory
-                        (directory-file-name default-directory))
-                   "-shell*"))
+         (default-project-shell-name (project-prefixed-buffer-name "shell"))
          (shell-buffer (get-buffer default-project-shell-name)))
     (if (and shell-buffer (not current-prefix-arg))
         (pop-to-buffer-same-window shell-buffer)
@@ -937,10 +934,7 @@ project-eshell
   (interactive)
   (defvar eshell-buffer-name)
   (let* ((default-directory (project-root (project-current t)))
-         (eshell-buffer-name
-          (concat "*" (file-name-nondirectory
-                       (directory-file-name default-directory))
-                  "-eshell*"))
+         (eshell-buffer-name (project-prefixed-buffer-name "eshell"))
          (eshell-buffer (get-buffer eshell-buffer-name)))
     (if (and eshell-buffer (not current-prefix-arg))
         (pop-to-buffer-same-window eshell-buffer)
@@ -1004,6 +998,7 @@ project-compilation-buffer-name-function
   "Function to compute the name of a project compilation buffer.
 If non-nil, it overrides `compilation-buffer-name-function' for
 `project-compile'."
+  :version "28.1"
   :group 'project
   :type '(choice (const :tag "Default" nil)
                  (const :tag "Prefixed with root directory name"

bug#47975: 28.0.50; Project prefixed buffer name

[Dmitry Gutov]

Hi Juri,

On 23.04.2021 19:32, Juri Linkov wrote:
> It seems the commit 08fab316a1 calls for more changes:

I stopped short of doing this keeping in mind the possibility for fixing 
and reusing uniquify not too far off in the future.

But please feel free to install, it shouldn't hurt either way.

bug#47975: 28.0.50; Project prefixed buffer name

[Juri Linkov]

tags 47975 fixed
close 47975 28.0.50
thanks

>> It seems the commit 08fab316a1 calls for more changes:
>
> I stopped short of doing this keeping in mind the possibility for fixing
> and reusing uniquify not too far off in the future.

Reusing uniquify is welcome, it could eliminate the need of redefining
the built-in commands to be able to generate unique compilation buffer names:

(defun my-project-compile ()
  (interactive)
  ;; Like ‘project-compile’ but generate unique buffer names:
  (let ((default-directory (project-root (project-current t)))
        (compilation-buffer-name-function
         (lambda (mode)
           (generate-new-buffer-name
            (project-prefixed-buffer-name mode)))))
    (compile (compilation-read-command (car compile-history)) nil)))

> But please feel free to install, it shouldn't hurt either way.

Now installed in master.