unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Madhu <enometh@meer.net>
To: 43356@debbugs.gnu.org
Subject: bug#43356: fix misguided
Date: Mon, 05 Oct 2020 08:01:32 +0530 (IST)	[thread overview]
Message-ID: <20201005.080132.876636723354002612.enometh@meer.net> (raw)
In-Reply-To: <87y2lfcn2m.fsf@Kittu.i-did-not-set--mail-host-address--so-tickle-me>

Please consider reverting the reverts and maintaining the old code
paths.  Old functionality is *not* available after the change commit
def34a20.

The restored "old behaiour" which is desired includes that

(a) *all* articles which are read when
(b) gnus-agent is t and
(c) and the group is agentised
are cached in the agent cache.

This means that 1) articles in groups which are not agentised should
not be cached in the agent cache. 2) when gnus-agent is nil articles
should not be cached in the agent cache.

The commit def34a20 suggests that one could get the old behaviour by
adding `gnus-agent-fetch-selected-article' to
`gnus-select-article-hook'

First problem is that this adds a 0.5 to 2 seconds overhead on
selecting each article.  Initial tests with ELP show that
`gnus-agent-fetch-articles' which is called for each article is over
100 times slower than than `gnus-agent-store-article' (which this
commit deprecates and removes from use).

When articles are missed by the hook there is no user interface to
ensure that the articles can be cached in the agent cache. There is no
way to fetch already fetched articles to the agent cache except by
selecting them again (painfully slow)

whether or not bug#8502 was an "erroneous feature request" this
particular "fix" is erroneous in the functionality it removes. here is
my rant on emacs-help:
https://lists.gnu.org/archive/html/help-gnu-emacs/2020-10/msg00037.html







  parent reply	other threads:[~2020-10-05  2:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12 10:21 bug#43356: 27.1; Gnus: Selected articles are unavoidably entered into the agent cache in an agentized group (while plugged) Ozhap
2020-09-13 14:46 ` Lars Ingebrigtsen
2020-10-05  2:31 ` Madhu [this message]
2020-10-08 10:20 ` bug#43356: fix misguided Ozhap
2020-10-09  4:27   ` bug#43356: Gnus: Selected articles are unavoidably entered into the agent cache in an agentized group (while plugged) Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005.080132.876636723354002612.enometh@meer.net \
    --to=enometh@meer.net \
    --cc=43356@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).