From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Madhu Newsgroups: gmane.emacs.bugs Subject: bug#43356: fix misguided Date: Mon, 05 Oct 2020 08:01:32 +0530 (IST) Message-ID: <20201005.080132.876636723354002612.enometh@meer.net> References: <87y2lfcn2m.fsf@Kittu.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31899"; mail-complaints-to="usenet@ciao.gmane.io" To: 43356@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 05 04:32:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPGIM-0008Ar-0A for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Oct 2020 04:32:10 +0200 Original-Received: from localhost ([::1]:45598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPGIK-0005YW-HN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 22:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPGIE-0005YB-0X for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 22:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPGID-0004Pr-NI for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 22:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPGID-0001jq-JC for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 22:32:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87y2lfcn2m.fsf@Kittu.i-did-not-set--mail-host-address--so-tickle-me> Resent-From: Madhu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Oct 2020 02:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43356 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 43356-submit@debbugs.gnu.org id=B43356.16018651026657 (code B ref 43356); Mon, 05 Oct 2020 02:32:01 +0000 Original-Received: (at 43356) by debbugs.gnu.org; 5 Oct 2020 02:31:42 +0000 Original-Received: from localhost ([127.0.0.1]:47120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPGHu-0001jJ-Ii for submit@debbugs.gnu.org; Sun, 04 Oct 2020 22:31:42 -0400 Original-Received: from smtp6.ctinetworks.com ([205.166.61.199]:56916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPGHt-0001jC-9o for 43356@debbugs.gnu.org; Sun, 04 Oct 2020 22:31:41 -0400 Original-Received: from localhost (unknown [117.193.7.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: enometh@meer.net) by smtp6.ctinetworks.com (Postfix) with ESMTPSA id 037D482099 for <43356@debbugs.gnu.org>; Sun, 4 Oct 2020 22:31:36 -0400 (EDT) X-Mailer: Mew version 6.8 on Emacs 28.0 X-ctinetworks-Information: Please contact the ISP for more information X-ctinetworks-MailScanner-ID: 037D482099.A5E46 X-ctinetworks-VirusCheck: Found to be clean X-ctinetworks-Watermark: 1602729100.52014@CCLYydp2X9rkSsJxEXGEUw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189780 Archived-At: Please consider reverting the reverts and maintaining the old code paths. Old functionality is *not* available after the change commit def34a20. The restored "old behaiour" which is desired includes that (a) *all* articles which are read when (b) gnus-agent is t and (c) and the group is agentised are cached in the agent cache. This means that 1) articles in groups which are not agentised should not be cached in the agent cache. 2) when gnus-agent is nil articles should not be cached in the agent cache. The commit def34a20 suggests that one could get the old behaviour by adding `gnus-agent-fetch-selected-article' to `gnus-select-article-hook' First problem is that this adds a 0.5 to 2 seconds overhead on selecting each article. Initial tests with ELP show that `gnus-agent-fetch-articles' which is called for each article is over 100 times slower than than `gnus-agent-store-article' (which this commit deprecates and removes from use). When articles are missed by the hook there is no user interface to ensure that the articles can be cached in the agent cache. There is no way to fetch already fetched articles to the agent cache except by selecting them again (painfully slow) whether or not bug#8502 was an "erroneous feature request" this particular "fix" is erroneous in the functionality it removes. here is my rant on emacs-help: https://lists.gnu.org/archive/html/help-gnu-emacs/2020-10/msg00037.html