unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#42937: [PATCH] * lisp/net/goto-addr.el: Add global minor mode for goto-addr-mode.
@ 2020-08-19 11:49 noah swainland via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2020-08-20 13:19 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: noah swainland via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-08-19 11:49 UTC (permalink / raw)
  To: 42937; +Cc: noah swainland

Found that I couldn't enable goto-addr either globally or through the
customize interface, so added it.

I found it unclear which version I should add in the key-value lines,
if this is wrong please let me know and I'll send another patch.
---
 lisp/net/goto-addr.el | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el
index 9436f45aa3..95f8a43144 100644
--- a/lisp/net/goto-addr.el
+++ b/lisp/net/goto-addr.el
@@ -280,6 +280,16 @@ Also fontifies the buffer appropriately (see `goto-address-fontify-p' and
       (widen)
       (goto-address-unfontify (point-min) (point-max)))))
 
+(defun turn-on-goto-addr-mode ()
+  (when (not goto-address-mode)
+    (goto-address-mode 1)))
+
+;;;###autoload
+(define-globalized-minor-mode global-goto-address-mode
+  goto-address-mode turn-on-goto-addr-mode
+  :group 'goto-address
+  :version "27.1")
+
 ;;;###autoload
 (define-minor-mode goto-address-prog-mode
   "Like `goto-address-mode', but only for comments and strings."
-- 
2.28.0


-- Email domain proudly hosted at https://migadu.com






^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#42937: [PATCH] * lisp/net/goto-addr.el: Add global minor mode for goto-addr-mode.
  2020-08-19 11:49 bug#42937: [PATCH] * lisp/net/goto-addr.el: Add global minor mode for goto-addr-mode noah swainland via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-08-20 13:19 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-20 13:19 UTC (permalink / raw)
  To: noah swainland; +Cc: 42937

noah swainland <noah@distinctly.pink> writes:

> Found that I couldn't enable goto-addr either globally or through the
> customize interface, so added it.

Makes sense to me.

> I found it unclear which version I should add in the key-value lines,
> if this is wrong please let me know and I'll send another patch.

Thanks; I altered it to "28.1" and applied it to the trunk.

The patch was small enough that it could be applied without doing a
copyright assignment, but further Emacs improvements would need an
assignment.  If you think that's likely, would you be willing to sign a
copyright assignment to the FSF?  If so, here's the way to get started:



Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-20 13:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 11:49 bug#42937: [PATCH] * lisp/net/goto-addr.el: Add global minor mode for goto-addr-mode noah swainland via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-20 13:19 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).