* bug#42822: Build of master db3a7df fails with MINGW64 console of MSYS2
@ 2020-08-11 23:27 Yasuhiro KIMURA
2020-08-12 14:18 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Yasuhiro KIMURA @ 2020-08-11 23:27 UTC (permalink / raw)
To: 42822
I checked out master db3a7df and built it with MINGW64 console of
MSYS2 on 64bit Windows 10 version 1909. Then I got following error.
----------------------------------------------------------------------
CC search.o
CC regex-emacs.o
CC undo.o
CC alloc.o
CC pdumper.o
pdumper.c: In function 'dump_read_all':
pdumper.c:5078:60: error: conversion from 'size_t' {aka 'long long unsigned int'} to 'unsigned int' may change value [-Werror=conversion]
5078 | ssize_t chunk = read (fd, (char *) buf + bytes_read, chunk_to_read);
| ^~~~~~~~~~~~~
cc1.exe: some warnings being treated as errors
make[1]: *** [Makefile:401: pdumper.o] Error 1
make[1]: Leaving directory '/c/Users/yasu/Work/Emacs/master/emacs/src'
make: *** [Makefile:424: src] Error 2
(MINGW64)yasu@rolling[1188]%
----------------------------------------------------------------------
According to the result of git bisect, following commit is the cause
of the problem.
----------------------------------------------------------------------
commit 9e4e4775364490d31406f247237934dd7f203808 (HEAD)
Author: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue Aug 11 02:16:54 2020 -0700
In pdumper, simplify INT_MAX computation
* src/pdumper.c (dump_read_all): Avoid unnecessary cast.
Also, round down to page size, as sysdep.c does.
Also, don t assume INT_MAX <= UINT_MAX (!).
----------------------------------------------------------------------
If I go back to master db3a7df and revert this commit, then build
completes successfully.
---
Yasuhiro KIMURA
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#42822: Build of master db3a7df fails with MINGW64 console of MSYS2
2020-08-11 23:27 bug#42822: Build of master db3a7df fails with MINGW64 console of MSYS2 Yasuhiro KIMURA
@ 2020-08-12 14:18 ` Eli Zaretskii
2020-08-13 0:52 ` Yasuhiro KIMURA
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2020-08-12 14:18 UTC (permalink / raw)
To: Yasuhiro KIMURA; +Cc: 42822
> Date: Wed, 12 Aug 2020 08:27:41 +0900 (JST)
> From: Yasuhiro KIMURA <yasu@utahime.org>
>
> I checked out master db3a7df and built it with MINGW64 console of
> MSYS2 on 64bit Windows 10 version 1909. Then I got following error.
>
> ----------------------------------------------------------------------
> CC search.o
> CC regex-emacs.o
> CC undo.o
> CC alloc.o
> CC pdumper.o
> pdumper.c: In function 'dump_read_all':
> pdumper.c:5078:60: error: conversion from 'size_t' {aka 'long long unsigned int'} to 'unsigned int' may change value [-Werror=conversion]
> 5078 | ssize_t chunk = read (fd, (char *) buf + bytes_read, chunk_to_read);
> | ^~~~~~~~~~~~~
> cc1.exe: some warnings being treated as errors
> make[1]: *** [Makefile:401: pdumper.o] Error 1
> make[1]: Leaving directory '/c/Users/yasu/Work/Emacs/master/emacs/src'
> make: *** [Makefile:424: src] Error 2
> (MINGW64)yasu@rolling[1188]%
Please try again, this should be fixed now.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#42822: Build of master db3a7df fails with MINGW64 console of MSYS2
2020-08-12 14:18 ` Eli Zaretskii
@ 2020-08-13 0:52 ` Yasuhiro KIMURA
2020-08-13 15:48 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Yasuhiro KIMURA @ 2020-08-13 0:52 UTC (permalink / raw)
To: eliz; +Cc: 42822
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: bug#42822: Build of master db3a7df fails with MINGW64 console of MSYS2
Date: Wed, 12 Aug 2020 17:18:33 +0300
> Please try again, this should be fixed now.
I confirmed the preblem is fixed with commit 4491a55a.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#42822: Build of master db3a7df fails with MINGW64 console of MSYS2
2020-08-13 0:52 ` Yasuhiro KIMURA
@ 2020-08-13 15:48 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2020-08-13 15:48 UTC (permalink / raw)
To: Yasuhiro KIMURA; +Cc: 42822-done
Yasuhiro KIMURA <yasu@utahime.org> writes:
> I confirmed the preblem is fixed with commit 4491a55a.
I'm therefore closing this bug report.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-13 15:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 23:27 bug#42822: Build of master db3a7df fails with MINGW64 console of MSYS2 Yasuhiro KIMURA
2020-08-12 14:18 ` Eli Zaretskii
2020-08-13 0:52 ` Yasuhiro KIMURA
2020-08-13 15:48 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).