From: Alan Third <alan@idiocy.org>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: 40845@debbugs.gnu.org, pipcet@gmail.com
Subject: bug#40845: SVG rendering issues
Date: Sat, 25 Apr 2020 18:46:51 +0100 [thread overview]
Message-ID: <20200425174651.GC82687@breton.holly.idiocy.org> (raw)
In-Reply-To: <bd59b4a7-6fcb-183b-9439-27fc239b8eaa@gmail.com>
On Sat, Apr 25, 2020 at 01:24:13PM -0400, Clément Pit-Claudel wrote:
> On 25/04/2020 13.02, Eli Zaretskii wrote:
> > IMO the foreground of an image shouldn't be affected by the
> > current face's foreground. Images should come with their own colors,
> > and be displayed like that. I think in the context of the discussion
> > that led to this bug report it's actually almost a must: we want
> > images with attractive colors to serve as the icons, we don't want
> > them to be affected by whatever face happens to be nearby.
>
> Yes, of course: if an image has a foreground color, it should be
> respected. But it's not uncommon for SVG images to not include a
> foreground color, as shown in the repro. In that case, the image
> should use the current foreground color, I think. (of course, a
> :foreground keyword, if any, should take precedence; that is issue
> 4).
Lars fixed the foreground issue for eww by wrapping svg files in
another svg. See svg--wrap-svg in shr.el (bug#37159).
I think this is the only practical way to handle svg files with no
foreground colour set. To do this when loading _any_ svg we’d probably
have to move it into create-image or image.c.
--
Alan Third
next prev parent reply other threads:[~2020-04-25 17:46 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 12:19 bug#40845: SVG rendering issues Clément Pit-Claudel
2020-04-25 14:34 ` Pip Cet
2020-04-25 15:30 ` Eli Zaretskii
2020-04-25 15:48 ` Pip Cet
2020-04-25 16:10 ` Eli Zaretskii
2020-04-25 17:38 ` Pip Cet
2020-04-25 18:07 ` Eli Zaretskii
2020-04-25 19:41 ` Pip Cet
2020-04-25 20:11 ` Eli Zaretskii
2020-04-26 10:15 ` Pip Cet
2020-04-26 14:38 ` Eli Zaretskii
2020-04-26 19:00 ` Pip Cet
2020-04-27 15:47 ` Eli Zaretskii
2020-04-25 15:46 ` Eli Zaretskii
2020-04-25 16:42 ` Clément Pit-Claudel
2020-04-25 17:02 ` Eli Zaretskii
2020-04-25 17:24 ` Clément Pit-Claudel
2020-04-25 17:46 ` Alan Third [this message]
2020-04-25 18:07 ` Pip Cet
2020-04-26 21:17 ` Alan Third
2020-04-26 22:48 ` Clément Pit-Claudel
2020-04-27 15:22 ` Alan Third
2020-04-27 16:04 ` Clément Pit-Claudel
2020-05-03 14:13 ` Alan Third
2020-05-03 14:18 ` Lars Ingebrigtsen
2020-05-03 16:07 ` Eli Zaretskii
2020-05-03 16:24 ` Alan Third
2020-05-03 16:49 ` Eli Zaretskii
2020-05-03 18:38 ` Alan Third
2020-05-03 19:17 ` Eli Zaretskii
2020-05-09 14:27 ` Alan Third
2020-05-09 19:54 ` Alan Third
2020-05-15 11:09 ` Eli Zaretskii
2020-05-15 21:40 ` Alan Third
2020-08-22 16:15 ` Alan Third
2020-08-22 16:28 ` Lars Ingebrigtsen
2020-08-22 16:54 ` Eli Zaretskii
2020-08-22 18:57 ` Alan Third
2020-08-22 19:17 ` Eli Zaretskii
2020-08-22 21:35 ` Alan Third
2020-08-23 5:47 ` Eli Zaretskii
2020-08-23 9:09 ` Alan Third
2020-08-23 9:11 ` Eli Zaretskii
2020-08-23 11:48 ` Alan Third
2020-08-23 12:05 ` Eli Zaretskii
2020-08-23 12:19 ` Alan Third
2020-08-23 12:23 ` Eli Zaretskii
2020-08-23 15:29 ` Alan Third
2020-08-23 15:43 ` Lars Ingebrigtsen
2020-08-23 16:08 ` Alan Third
2020-08-23 16:38 ` Lars Ingebrigtsen
2020-04-27 2:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425174651.GC82687@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=40845@debbugs.gnu.org \
--cc=cpitclaudel@gmail.com \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).