From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#40845: SVG rendering issues Date: Sat, 25 Apr 2020 18:46:51 +0100 Message-ID: <20200425174651.GC82687@breton.holly.idiocy.org> References: <72ebf5eb-6b00-ebb4-dab3-a047e35ae1ae@gmail.com> <83mu6z7em5.fsf@gnu.org> <17307310-2afc-7941-8a48-5cd345d1ad63@gmail.com> <83k1237b2a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62138"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40845@debbugs.gnu.org, pipcet@gmail.com To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 25 19:47:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSOtT-000G4Q-8A for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 19:47:11 +0200 Original-Received: from localhost ([::1]:42192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSOtS-0002s0-9I for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 13:47:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51862) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSOtK-0002rt-OL for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 13:47:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSOtK-0006I6-7L for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 13:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSOtJ-0006HU-Rc for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 13:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSOtJ-0000Pp-MV for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 13:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Apr 2020 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40845 X-GNU-PR-Package: emacs Original-Received: via spool by 40845-submit@debbugs.gnu.org id=B40845.15878368201590 (code B ref 40845); Sat, 25 Apr 2020 17:47:01 +0000 Original-Received: (at 40845) by debbugs.gnu.org; 25 Apr 2020 17:47:00 +0000 Original-Received: from localhost ([127.0.0.1]:60301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSOtH-0000Pa-Uq for submit@debbugs.gnu.org; Sat, 25 Apr 2020 13:47:00 -0400 Original-Received: from idiocy.org ([217.169.17.33]:53556 helo=breton.holly.idiocy.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSOtG-0000PL-6T for 40845@debbugs.gnu.org; Sat, 25 Apr 2020 13:46:58 -0400 Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id A38BF20224E6CF; Sat, 25 Apr 2020 18:46:51 +0100 (BST) Mail-Followup-To: Alan Third , =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel , Eli Zaretskii , 40845@debbugs.gnu.org, pipcet@gmail.com Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179021 Archived-At: On Sat, Apr 25, 2020 at 01:24:13PM -0400, Clément Pit-Claudel wrote: > On 25/04/2020 13.02, Eli Zaretskii wrote: > > IMO the foreground of an image shouldn't be affected by the > > current face's foreground. Images should come with their own colors, > > and be displayed like that. I think in the context of the discussion > > that led to this bug report it's actually almost a must: we want > > images with attractive colors to serve as the icons, we don't want > > them to be affected by whatever face happens to be nearby. > > Yes, of course: if an image has a foreground color, it should be > respected. But it's not uncommon for SVG images to not include a > foreground color, as shown in the repro. In that case, the image > should use the current foreground color, I think. (of course, a > :foreground keyword, if any, should take precedence; that is issue > 4). Lars fixed the foreground issue for eww by wrapping svg files in another svg. See svg--wrap-svg in shr.el (bug#37159). I think this is the only practical way to handle svg files with no foreground colour set. To do this when loading _any_ svg we’d probably have to move it into create-image or image.c. -- Alan Third