From: Jean Louis <bugs@gnu.support>
To: Juri Linkov <juri@linkov.net>
Cc: 37496@debbugs.gnu.org
Subject: bug#37496: 27.0.50; C-s failing to search
Date: Tue, 8 Oct 2019 14:16:22 +0200 [thread overview]
Message-ID: <20191008121622.GZ7291@protected.rcdrun.com> (raw)
In-Reply-To: <87sgo46a4q.fsf@mail.linkov.net>
Dear Juri,
Thank you much for M-x isearch-diagnostics function. I am keeping it
ready for case that I get into problem again. I was editing 600
directories and many PDF file names inside, and there is yet left to
be edited, so I hope to encounter the same problem again.
I would not patch that now as I cannot reproduce the bug
intentionally, I can just hope it will happen again and would let you
all know.
Jean
* Juri Linkov <juri@linkov.net> [2019-10-07 21:01]:
> Next time you encounter this problem please try running this diagnostics
> with just 'M-x isearch-diagnostics RET' in the buffer where isearch fails:
>
> (defun isearch-diagnostics ()
> (interactive)
> (let* ((variables
> '(major-mode
> buffer-read-only
> isearch-mode
> isearch-success
> isearch-error
> isearch-wrapped
> isearch-adjusted
> isearch-suspended
> isearch-regexp
> isearch-case-fold-search
> isearch-invisible
> isearch-hidden
> isearch-allow-scroll
> isearch-search-fun-function
> isearch-wrap-function
> isearch-push-state-function
> isearch-mode-hook
> isearch-update-post-hook
> isearch-mode-end-hook
> isearch-filter-predicate
> dired-isearch-filenames
> dired-isearch-filenames-mode))
> (diagnostics
> (concat
> (mapconcat
> (lambda (v)
> (format "%s: %s %s" v
> (cl-prin1-to-string (and (boundp v) (buffer-local-value v (current-buffer))))
> (cl-prin1-to-string (and (boundp v) (default-value v)))))
> variables "\n")
> (format "\nany read-only: %S\n" (text-property-any (point-min) (point-max) 'read-only t)))))
> (display-buffer
> (with-current-buffer (get-buffer-create "*isearch-diagnostics*")
> (erase-buffer)
> (insert diagnostics)
> (current-buffer)))))
>
> From what I see wdired doesn't restore a previous value of isearch-filter-predicate.
> This is fine as long as there are no read-only properties kept in the
> Dired buffer, but it seems in your case read-only properties might be
> still present after finishing Wdired-mode. If you can reproduce the bug
> please also try the following patch that could fix it:
>
> diff --git a/lisp/wdired.el b/lisp/wdired.el
> index 44f083bb7f..35f1b5ebbd 100644
> --- a/lisp/wdired.el
> +++ b/lisp/wdired.el
> @@ -357,6 +357,8 @@ wdired-change-to-dired-mode
> (remove-text-properties
> (point-min) (point-max)
> '(front-sticky nil rear-nonsticky nil read-only nil keymap nil)))
> + (remove-function (local 'isearch-filter-predicate)
> + #'wdired-isearch-filter-read-only)
> (use-local-map dired-mode-map)
> (force-mode-line-update)
> (setq buffer-read-only t)
>
next prev parent reply other threads:[~2019-10-08 12:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 9:51 bug#37496: 27.0.50; C-s failing to search Jean Louis
2019-09-24 10:38 ` Eli Zaretskii
2019-09-24 11:32 ` Jean Louis
2019-09-25 20:45 ` Jean Louis
2019-09-26 7:02 ` Eli Zaretskii
2019-09-26 7:22 ` Jean Louis
2019-09-26 7:39 ` Eli Zaretskii
2019-09-26 7:50 ` Jean Louis
2019-09-26 8:06 ` Eli Zaretskii
2019-09-26 8:54 ` Jean Louis
2019-09-26 9:50 ` Eli Zaretskii
2019-09-28 11:06 ` Jean Louis
2019-09-28 12:13 ` Eli Zaretskii
2019-09-28 12:19 ` Jean Louis
2019-09-28 13:40 ` Eli Zaretskii
2019-09-28 15:08 ` Jean Louis
2019-10-03 18:32 ` Jean Louis
2019-10-03 18:56 ` Eli Zaretskii
2019-10-03 19:14 ` Jean Louis
2019-10-03 19:46 ` Eli Zaretskii
2019-10-03 19:51 ` Jean Louis
2019-10-04 7:17 ` Eli Zaretskii
2019-10-04 14:33 ` Jean Louis
2019-10-07 18:17 ` Juri Linkov
2019-10-08 12:16 ` Jean Louis [this message]
2020-01-28 0:12 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008121622.GZ7291@protected.rcdrun.com \
--to=bugs@gnu.support \
--cc=37496@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).