From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.bugs Subject: bug#37496: 27.0.50; C-s failing to search Date: Tue, 8 Oct 2019 14:16:22 +0200 Message-ID: <20191008121622.GZ7291@protected.rcdrun.com> References: <20190926085433.GN4022@protected.rcdrun.com> <83zhirl73d.fsf@gnu.org> <20191003183212.GJ6957@protected.rcdrun.com> <835zl57j4h.fsf@gnu.org> <20191003191433.GA14781@protected.rcdrun.com> <8336g97gt5.fsf@gnu.org> <20191003195105.GE14781@protected.rcdrun.com> <831rvt6kuj.fsf@gnu.org> <20191004143316.GI4341@protected.rcdrun.com> <87sgo46a4q.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="214055"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 37496@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 08 14:17:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHoQj-000tYp-U6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 14:17:30 +0200 Original-Received: from localhost ([::1]:54736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHoQh-00009b-W6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 08:17:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56647) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHoQL-00009J-Mm for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 08:17:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHoQK-0007DQ-FV for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 08:17:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40871) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHoQK-0007DA-C8 for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 08:17:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHoQJ-0002WE-54 for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 08:17:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jean Louis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2019 12:17:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37496 X-GNU-PR-Package: emacs Original-Received: via spool by 37496-submit@debbugs.gnu.org id=B37496.15705369969645 (code B ref 37496); Tue, 08 Oct 2019 12:17:03 +0000 Original-Received: (at 37496) by debbugs.gnu.org; 8 Oct 2019 12:16:36 +0000 Original-Received: from localhost ([127.0.0.1]:49692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHoPr-0002VV-Lf for submit@debbugs.gnu.org; Tue, 08 Oct 2019 08:16:35 -0400 Original-Received: from stw1.rcdrun.com ([217.170.207.13]:40345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHoPo-0002VE-UG for 37496@debbugs.gnu.org; Tue, 08 Oct 2019 08:16:33 -0400 Original-Received: from protected.rcdrun.com ([::ffff:103.106.100.3]) (AUTH: PLAIN admin, TLS: TLS1.2,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 0000000000073C6A.000000005D9C7E19.00001A7D; Tue, 08 Oct 2019 05:16:25 -0700 Content-Disposition: inline In-Reply-To: <87sgo46a4q.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168641 Archived-At: Dear Juri, Thank you much for M-x isearch-diagnostics function. I am keeping it ready for case that I get into problem again. I was editing 600 directories and many PDF file names inside, and there is yet left to be edited, so I hope to encounter the same problem again. I would not patch that now as I cannot reproduce the bug intentionally, I can just hope it will happen again and would let you all know. Jean * Juri Linkov [2019-10-07 21:01]: > Next time you encounter this problem please try running this diagnostics > with just 'M-x isearch-diagnostics RET' in the buffer where isearch fails: > > (defun isearch-diagnostics () > (interactive) > (let* ((variables > '(major-mode > buffer-read-only > isearch-mode > isearch-success > isearch-error > isearch-wrapped > isearch-adjusted > isearch-suspended > isearch-regexp > isearch-case-fold-search > isearch-invisible > isearch-hidden > isearch-allow-scroll > isearch-search-fun-function > isearch-wrap-function > isearch-push-state-function > isearch-mode-hook > isearch-update-post-hook > isearch-mode-end-hook > isearch-filter-predicate > dired-isearch-filenames > dired-isearch-filenames-mode)) > (diagnostics > (concat > (mapconcat > (lambda (v) > (format "%s: %s %s" v > (cl-prin1-to-string (and (boundp v) (buffer-local-value v (current-buffer)))) > (cl-prin1-to-string (and (boundp v) (default-value v))))) > variables "\n") > (format "\nany read-only: %S\n" (text-property-any (point-min) (point-max) 'read-only t))))) > (display-buffer > (with-current-buffer (get-buffer-create "*isearch-diagnostics*") > (erase-buffer) > (insert diagnostics) > (current-buffer))))) > > From what I see wdired doesn't restore a previous value of isearch-filter-predicate. > This is fine as long as there are no read-only properties kept in the > Dired buffer, but it seems in your case read-only properties might be > still present after finishing Wdired-mode. If you can reproduce the bug > please also try the following patch that could fix it: > > diff --git a/lisp/wdired.el b/lisp/wdired.el > index 44f083bb7f..35f1b5ebbd 100644 > --- a/lisp/wdired.el > +++ b/lisp/wdired.el > @@ -357,6 +357,8 @@ wdired-change-to-dired-mode > (remove-text-properties > (point-min) (point-max) > '(front-sticky nil rear-nonsticky nil read-only nil keymap nil))) > + (remove-function (local 'isearch-filter-predicate) > + #'wdired-isearch-filter-read-only) > (use-local-map dired-mode-map) > (force-mode-line-update) > (setq buffer-read-only t) >