bug#32882: 27.0.50; thin border around emacs frame on macOS mojave

bug#32882: 27.0.50; thin border around emacs frame on macOS mojave

[Aaron Jensen]

emacs -Q
M-x load-theme manoj-dark

See
https://dzwonsemrish7.cloudfront.net/items/272S1013403W1e1i2W1Y/Image%202018-09-29%20at%2011.44.39%20PM.png

vs

https://cl.ly/115ddf656a41/Image%202018-09-30%20at%2012.04.17%20AM.png

Since upgrading to Mojave there is a thin border around the frame that
was not there prior to Mojave if my memory serves. The border's color
appears to be influenced by the theme, but I don't know how. Is there an
option for this I don't know about or is this some unintentional change
triggered by Mojave?

In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin18.0.0, NS appkit-1671.00 Version 10.14 (Build 18A391))
 of 2018-09-29 built on aaron-mbt.local
Repository revision: 6217746dd64b43a2a2b3b66ab50cfbbfc984f36c
Windowing system distributor 'Apple', version 10.3.1671
System Description:  Mac OS X 10.14

bug#32882: 27.0.50; thin border around emacs frame on macOS mojave

[Alan Third]

On Sun, Sep 30, 2018 at 12:05:52AM -0700, Aaron Jensen wrote:
> 
> emacs -Q
> M-x load-theme manoj-dark
> 
> See
> https://dzwonsemrish7.cloudfront.net/items/272S1013403W1e1i2W1Y/Image%202018-09-29%20at%2011.44.39%20PM.png
> 
> vs
> 
> https://cl.ly/115ddf656a41/Image%202018-09-30%20at%2012.04.17%20AM.png
> 
> Since upgrading to Mojave there is a thin border around the frame that
> was not there prior to Mojave if my memory serves. The border's color
> appears to be influenced by the theme, but I don't know how. Is there an
> option for this I don't know about or is this some unintentional change
> triggered by Mojave?

Hi Aaron,

My money is on this being related to Mojave’s new theming stuff. If
you look very closely at the second screenshot you’ll notice there is
actually a black border round the frame.

Are you using the dark theme in macOS?

Perhaps try changing ns-appearance to see if it affects the colours.

FWIW, I think we tell macOS what our background and foreground colours
are, but the colour there doesn’t seem to match either so I wonder if
it’s automatically choosing a colour that will show up against the
background. I take it this border doesn’t exist on non‐emacs windows?
-- 
Alan Third

bug#32882: 27.0.50; thin border around emacs frame on macOS mojave

[Alan Third]

(I don’t know if you intentionally removed the bug tracker, but I’ve
put it back in.)

On Sun, Sep 30, 2018 at 09:51:40AM -0700, Aaron Jensen wrote:
> On September 30, 2018 at 1:54:05 AM, Alan Third
> (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> 
> > Hi Aaron,
> >
> > My money is on this being related to Mojave’s new theming stuff. If
> > you look very closely at the second screenshot you’ll notice there is
> > actually a black border round the frame.
> 
> The black border on iTerm, AFAICT is on the very outside and only 1px
> wide. Emacs has that as well, but it also has a 2px colored border.

I wonder if it’s the internal border. It’s not properly supported on
the NS port for some reason, and therefore should always be the
background colour. But it defaults to 2 pixels. Try:

(set-frame-parameter nil 'internal-border-width 0)

> It’s likely a shame of the background color. I wonder if there’s a way
> to opt out of it, it almost gives the windows a beveled feel. I’ll
> take a look at the iTerm2 codebase and ask the maintainer if I can’t
> figure it out.
> Some other windows have it too, but not all of them.

It looks like it’s the same colour as the titlebar text, but that
might just be coincidence.

(By the way, your manoj-dark appears to be significantly different
than mine. Are you using a modified version?)
-- 
Alan Third

bug#32882: 27.0.50; thin border around emacs frame on macOS mojave

[Aaron Jensen]

On September 30, 2018 at 11:16:19 AM, Alan Third
(alan@idiocy.org(mailto:alan@idiocy.org)) wrote:

> (I don’t know if you intentionally removed the bug tracker, but I’ve
> put it back in.)

I did not, thank you. My email client was just murdered by Slack so
I’m getting used to a new one...

> I wonder if it’s the internal border. It’s not properly supported on
> the NS port for some reason, and therefore should always be the
> background colour. But it defaults to 2 pixels. Try:
>
> (set-frame-parameter nil 'internal-border-width 0)

Oh, I didn’t know about this. I like it, but it doesn’t fix the issue.
It does make it seem like whatever is rendered on the edges is just
lightened, as it lightened my modeline:

https://cl.ly/8332c24f8b90/Image%202018-09-30%20at%2011.21.30%20AM.png

> > It’s likely a shame of the background color. I wonder if there’s a way
> > to opt out of it, it almost gives the windows a beveled feel. I’ll
> > take a look at the iTerm2 codebase and ask the maintainer if I can’t
> > figure it out.
> > Some other windows have it too, but not all of them.
>
> It looks like it’s the same colour as the titlebar text, but that
> might just be coincidence.

It’s different on my theme. My guess is that this is a new default
window behavior to give windows a more 3d appearance. I do not know
how to opt out of it yet. Hopefully the iTerm maintainer gets back to
me.

> (By the way, your manoj-dark appears to be significantly different
> than mine. Are you using a modified version?)

Sorry, I should have clarified, the screenshots were of night-owl,
which I’m using. I only specified manoj-dark in the repro because it
is built-in.

Aaron

bug#32882: 27.0.50; thin border around emacs frame on macOS mojave

[Aaron Jensen]

On September 30, 2018 at 11:24:56 AM, Aaron Jensen
(aaronjensen@gmail.com(mailto:aaronjensen@gmail.com)) wrote:

> It’s different on my theme. My guess is that this is a new default window behavior to give windows a more 3d appearance. I do not know how to opt out of it yet. Hopefully the iTerm maintainer gets back to me.

FWIW, after living with it for a bit I’m fine with the border. I’m
fine without it too, but I don’t really care enough to pursue it. Feel
free to close if you like or maybe someone can hunt it down.

Thanks,

Aaron