* bug#28340: 26.0.50; xterm frame titles
@ 2017-09-03 21:37 Mark Oteiza
2017-09-04 4:16 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Mark Oteiza @ 2017-09-03 21:37 UTC (permalink / raw)
To: 28340
Wishlist item.
Hi,
I tacked setting window/iconified window titles into term/xterm.el, but
found a quirk I suspect is related to Bug#18137 (which refers to
42fe2e88d and Bug#15025). Because clients don't always have focus,
opening a new client won't trigger hooks that I would think trigger,
perhaps even after-make-frame-functions or window-size-change-functions.
diff --git a/lisp/term/xterm.el b/lisp/term/xterm.el
index e6d224dd3d..03dd516ebf 100644
--- a/lisp/term/xterm.el
+++ b/lisp/term/xterm.el
@@ -802,6 +802,7 @@ terminal-init-xterm
(when (memq 'setSelection xterm-extra-capabilities)
(xterm--init-activate-set-selection)))
+ (xterm--init-frame-title)
;; Unconditionally enable bracketed paste mode: terminals that don't
;; support it just ignore the sequence.
(xterm--init-bracketed-paste-mode)
@@ -828,6 +829,22 @@ xterm--init-activate-set-selection
"Terminal initialization for `gui-set-selection'."
(set-terminal-parameter nil 'xterm--set-selection t))
+(defun xterm--init-frame-title ()
+ "Terminal initialization for `gui-set-selection'."
+ (xterm-set-window-title)
+ (add-hook 'post-command-hook 'xterm-set-window-title)
+ (add-hook 'minibuffer-exit-hook 'xterm-set-window-title))
+
+(defun xterm-set-window-title ()
+ "Set the window title of the Xterm with the current Emacs frame."
+ (send-string-to-terminal
+ (format "\e]2;%s\a" (format-mode-line frame-title-format))))
+
+(defun xterm-set-icon-title ()
+ "Set the window title of the Xterm with the current Emacs frame."
+ (send-string-to-terminal
+ (format "\e]1;%s\a" (format-mode-line icon-title-format))))
+
(defun xterm--selection-char (type)
(pcase type
('PRIMARY "p")
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#28340: 26.0.50; xterm frame titles
2017-09-03 21:37 bug#28340: 26.0.50; xterm frame titles Mark Oteiza
@ 2017-09-04 4:16 ` Eli Zaretskii
2017-09-12 1:21 ` Mark Oteiza
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2017-09-04 4:16 UTC (permalink / raw)
To: Mark Oteiza; +Cc: 28340
> From: Mark Oteiza <mvoteiza@udel.edu>
> Date: Sun, 03 Sep 2017 17:37:24 -0400
>
> Wishlist item.
>
> Hi,
>
> I tacked setting window/iconified window titles into term/xterm.el, but
Thanks. This needs a NEWS entry, and I think there should be a
defcustom to turn this off, for those who'd like the default title
provided by xterm.
> found a quirk I suspect is related to Bug#18137 (which refers to
> 42fe2e88d and Bug#15025). Because clients don't always have focus,
> opening a new client won't trigger hooks that I would think trigger,
> perhaps even after-make-frame-functions or window-size-change-functions.
Maybe one of the hooks provided by server.el would fit the bill?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#28340: 26.0.50; xterm frame titles
2017-09-04 4:16 ` Eli Zaretskii
@ 2017-09-12 1:21 ` Mark Oteiza
2017-09-20 7:47 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Mark Oteiza @ 2017-09-12 1:21 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 28340
On 04/09/17 at 07:16am, Eli Zaretskii wrote:
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > Date: Sun, 03 Sep 2017 17:37:24 -0400
> > I tacked setting window/iconified window titles into term/xterm.el, but
>
> Thanks. This needs a NEWS entry, and I think there should be a
> defcustom to turn this off, for those who'd like the default title
> provided by xterm.
Ok.
> > found a quirk I suspect is related to Bug#18137 (which refers to
> > 42fe2e88d and Bug#15025). Because clients don't always have focus,
> > opening a new client won't trigger hooks that I would think trigger,
> > perhaps even after-make-frame-functions or window-size-change-functions.
>
> Maybe one of the hooks provided by server.el would fit the bill?
Nope, none of those appear relevant, and hooking into them does nothing
apparent. Even doing the following, I get the title as the selected
buffer in the previously selected frame.
Messaging (frame-list) in xterm-test shows that the car of the list is
always the new frame, but still the frame title is incorrect--a new
frame created by emacsclient -t ends up on the scratch buffer. I say
"ends up" because sometimes I see another buffer flash before I see the
scratch buffer. This all seems a little buggy to me, but I know
Bug#18137 and its ancestors were tough.
(defun xterm--init-frame-title ()
"Terminal initialization for `gui-set-selection'."
(xterm-set-window-title)
(add-hook 'after-make-frame-functions 'xterm-test)
(add-hook 'server-switch-hook 'xterm-test)
;; (add-hook 'window-size-change-functions 'xterm-set-window-title)
;; (add-hook 'post-command-hook 'xterm-set-window-title)
;; (add-hook 'minibuffer-exit-hook 'xterm-set-window-title)
)
(defun xterm-test (&optional frame)
(select-frame (car (frame-list)))
(xterm-set-window-title frame))
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#28340: 26.0.50; xterm frame titles
2017-09-12 1:21 ` Mark Oteiza
@ 2017-09-20 7:47 ` Eli Zaretskii
2017-09-20 12:23 ` Mark Oteiza
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2017-09-20 7:47 UTC (permalink / raw)
To: Mark Oteiza; +Cc: 28340
> Date: Mon, 11 Sep 2017 21:21:22 -0400
> From: Mark Oteiza <mvoteiza@udel.edu>
> Cc: 28340@debbugs.gnu.org
>
> > Maybe one of the hooks provided by server.el would fit the bill?
>
> Nope, none of those appear relevant, and hooking into them does nothing
> apparent. Even doing the following, I get the title as the selected
> buffer in the previously selected frame.
>
> Messaging (frame-list) in xterm-test shows that the car of the list is
> always the new frame, but still the frame title is incorrect--a new
> frame created by emacsclient -t ends up on the scratch buffer. I say
> "ends up" because sometimes I see another buffer flash before I see the
> scratch buffer. This all seems a little buggy to me, but I know
> Bug#18137 and its ancestors were tough.
What about window-configuration-change-hook, does that help? You
could set some flag in after-make-frame-functions, and then test and
reset that flag in window-configuration-change-hook, when you see that
a buffer is switched in the frame. Would that work?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#28340: 26.0.50; xterm frame titles
2017-09-20 7:47 ` Eli Zaretskii
@ 2017-09-20 12:23 ` Mark Oteiza
2017-09-20 13:47 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Mark Oteiza @ 2017-09-20 12:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 28340
On 20/09/17 at 07:47am, Eli Zaretskii wrote:
> > Date: Mon, 11 Sep 2017 21:21:22 -0400
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > Cc: 28340@debbugs.gnu.org
> >
> > > Maybe one of the hooks provided by server.el would fit the bill?
> >
> > Nope, none of those appear relevant, and hooking into them does nothing
> > apparent. Even doing the following, I get the title as the selected
> > buffer in the previously selected frame.
> >
> > Messaging (frame-list) in xterm-test shows that the car of the list is
> > always the new frame, but still the frame title is incorrect--a new
> > frame created by emacsclient -t ends up on the scratch buffer. I say
> > "ends up" because sometimes I see another buffer flash before I see the
> > scratch buffer. This all seems a little buggy to me, but I know
> > Bug#18137 and its ancestors were tough.
>
> What about window-configuration-change-hook, does that help? You
> could set some flag in after-make-frame-functions, and then test and
> reset that flag in window-configuration-change-hook, when you see that
> a buffer is switched in the frame. Would that work?
This appears to work, thank you. Please see attached.
diff --git a/lisp/term/xterm.el b/lisp/term/xterm.el
index 4f79703833..a11acbc4db 100644
--- a/lisp/term/xterm.el
+++ b/lisp/term/xterm.el
@@ -68,6 +68,11 @@ xterm-max-cut-length
:version "25.1"
:type 'integer)
+(defcustom xterm-set-window-title t
+ "Whether Emacs should set window titles to an Emacs frame in an XTerm."
+ :version "27.1"
+ :type 'boolean)
+
(defconst xterm-paste-ending-sequence "\e[201~"
"Characters send by the terminal to end a bracketed paste.")
@@ -802,6 +807,8 @@ terminal-init-xterm
(when (memq 'setSelection xterm-extra-capabilities)
(xterm--init-activate-set-selection)))
+ (when xterm-set-window-title
+ (xterm--init-frame-title))
;; Unconditionally enable bracketed paste mode: terminals that don't
;; support it just ignore the sequence.
(xterm--init-bracketed-paste-mode)
@@ -828,6 +835,31 @@ xterm--init-activate-set-selection
"Terminal initialization for `gui-set-selection'."
(set-terminal-parameter nil 'xterm--set-selection t))
+(defun xterm--init-frame-title ()
+ "Terminal initialization for `gui-set-selection'."
+ (xterm-set-window-title)
+ (add-hook 'after-make-frame-functions 'xterm-set-window-title-flag)
+ (add-hook 'window-configuration-change-hook 'xterm-unset-window-title-flag)
+ (add-hook 'post-command-hook 'xterm-set-window-title)
+ (add-hook 'minibuffer-exit-hook 'xterm-set-window-title))
+
+(defvar xterm-window-title-flag nil
+ "Whether the a new frame has been created, calling for a title update.")
+
+(defun xterm-set-window-title-flag (_frame)
+ (setq xterm-window-title-flag t))
+
+(defun xterm-unset-window-title-flag ()
+ (when xterm-window-title-flag
+ (setq xterm-window-title-flag nil)
+ (xterm-set-window-title)))
+
+(defun xterm-set-window-title (&optional terminal)
+ "Set the window title of the Xterm with the current Emacs frame."
+ (send-string-to-terminal
+ (format "\e]2;%s\a" (format-mode-line frame-title-format))
+ terminal))
+
(defun xterm--selection-char (type)
(pcase type
('PRIMARY "p")
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#28340: 26.0.50; xterm frame titles
2017-09-20 12:23 ` Mark Oteiza
@ 2017-09-20 13:47 ` Eli Zaretskii
2017-09-20 16:06 ` Mark Oteiza
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2017-09-20 13:47 UTC (permalink / raw)
To: Mark Oteiza; +Cc: 28340
> Date: Wed, 20 Sep 2017 08:23:51 -0400
> From: Mark Oteiza <mvoteiza@udel.edu>
> Cc: 28340@debbugs.gnu.org
>
> > What about window-configuration-change-hook, does that help? You
> > could set some flag in after-make-frame-functions, and then test and
> > reset that flag in window-configuration-change-hook, when you see that
> > a buffer is switched in the frame. Would that work?
>
> This appears to work, thank you. Please see attached.
Thanks, this LGTM. It needs a NEWS entry about the new defcustom, and
then it can go in.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#28340: 26.0.50; xterm frame titles
2017-09-20 13:47 ` Eli Zaretskii
@ 2017-09-20 16:06 ` Mark Oteiza
0 siblings, 0 replies; 7+ messages in thread
From: Mark Oteiza @ 2017-09-20 16:06 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 28340-done
On 20/09/17 at 01:47pm, Eli Zaretskii wrote:
> > Date: Wed, 20 Sep 2017 08:23:51 -0400
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > Cc: 28340@debbugs.gnu.org
> >
> > > What about window-configuration-change-hook, does that help? You
> > > could set some flag in after-make-frame-functions, and then test and
> > > reset that flag in window-configuration-change-hook, when you see that
> > > a buffer is switched in the frame. Would that work?
> >
> > This appears to work, thank you. Please see attached.
>
> Thanks, this LGTM. It needs a NEWS entry about the new defcustom, and
> then it can go in.
Thanks. Done, pushed as 3a09343e
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-20 16:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-03 21:37 bug#28340: 26.0.50; xterm frame titles Mark Oteiza
2017-09-04 4:16 ` Eli Zaretskii
2017-09-12 1:21 ` Mark Oteiza
2017-09-20 7:47 ` Eli Zaretskii
2017-09-20 12:23 ` Mark Oteiza
2017-09-20 13:47 ` Eli Zaretskii
2017-09-20 16:06 ` Mark Oteiza
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).