unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Toby Cubitt <toby-undo-tree@dr-qubit.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 16377@debbugs.gnu.org, Barry OReilly <gundaetiapo@gmail.com>,
	Stefan Monnier <monnier@IRO.UMontreal.CA>
Subject: bug#16377: Undo Tree regression: (error "Unrecognized entry in undo list undo-tree-canary")
Date: Thu, 6 Jul 2017 10:47:39 +0100	[thread overview]
Message-ID: <20170706094739.GA21603@marvin.cs.ucl.ac.uk> (raw)
In-Reply-To: <20170706090256.GA20017@marvin.cs.ucl.ac.uk>

On Thu, Jul 06, 2017 at 10:02:56AM +0100, Toby Cubitt wrote:
> I'm way behind on dealing with undo-tree bug reports whilst busy with
> "real life". #16377 is a very helpful bug report, which I can now
> reproduce much more reliably with current Emacs version than I could when
> it was originally reported. I hope to have time for a mammoth undo-tree
> maintenance session later this summer. If that works out, I'll look into
> it then.

Scratch that. I can't reproduce #16377 in Emacs 25.2.1, undo-tree git
head, except by calling undo-tree-undo/redo commands via M-x in buffers
where undo-tree-mode is disabled.

Calling undo-tree commands with undo-tree-mode disabled is entirely
expected to mess up buffer-undo-list. I've added checks in git to all the
undo-tree interactive commands to throw a user-error if they're called
when undo-tree is not enabled, to guard against this.

But that has nothing to do with the original bug, which appears to
already be fixed in git.

Toby
-- 
Dr T. S. Cubitt
Royal Society University Research Fellow
Quantum Information Theory
Department of Computer Science
University College London

email: tsc25@cantab.net
web:   www.dr-qubit.org






      reply	other threads:[~2017-07-06  9:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07  0:32 bug#16377: Undo Tree regression: (error "Unrecognized entry in undo list undo-tree-canary") Barry OReilly
2014-01-07  4:14 ` Toby Cubitt
2014-01-22  3:23   ` Barry OReilly
2014-01-22 17:08     ` bug#16523: " Toby Cubitt
2014-01-08  3:37 ` bug#16377: " Toby Cubitt
2014-01-22  0:05   ` Barry OReilly
     [not found]     ` <20140122141701.GA6728@c3po>
2014-01-22 15:26       ` Barry OReilly
2014-01-22 17:05         ` Toby Cubitt
2014-01-22 18:56           ` Stefan Monnier
2014-01-22 21:30             ` Toby Cubitt
2017-07-06  0:33 ` Keith David Bershatsky
2017-07-06  5:01 ` Keith David Bershatsky
2017-07-06  5:35   ` Stefan Monnier
2017-07-06  6:25 ` Keith David Bershatsky
2017-07-06  9:02   ` Toby Cubitt
2017-07-06  9:47     ` Toby Cubitt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706094739.GA21603@marvin.cs.ucl.ac.uk \
    --to=toby-undo-tree@dr-qubit.org \
    --cc=16377@debbugs.gnu.org \
    --cc=esq@lawlist.com \
    --cc=gundaetiapo@gmail.com \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).