From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Toby Cubitt Newsgroups: gmane.emacs.bugs Subject: bug#16377: Undo Tree regression: (error "Unrecognized entry in undo list undo-tree-canary") Date: Thu, 6 Jul 2017 10:47:39 +0100 Message-ID: <20170706094739.GA21603@marvin.cs.ucl.ac.uk> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1499334504 20806 195.159.176.226 (6 Jul 2017 09:48:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Jul 2017 09:48:24 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: 16377@debbugs.gnu.org, Barry OReilly , Stefan Monnier To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 06 11:48:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dT3OQ-0004m8-MF for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Jul 2017 11:48:14 +0200 Original-Received: from localhost ([::1]:50327 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dT3OS-0008JS-U2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Jul 2017 05:48:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dT3OJ-0008I0-Jc for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2017 05:48:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dT3OF-0007vv-Oa for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2017 05:48:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51531) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dT3OF-0007vr-Kl for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2017 05:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dT3OE-0005E6-B3 for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2017 05:48:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Toby Cubitt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jul 2017 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16377 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16377-submit@debbugs.gnu.org id=B16377.149933446920071 (code B ref 16377); Thu, 06 Jul 2017 09:48:02 +0000 Original-Received: (at 16377) by debbugs.gnu.org; 6 Jul 2017 09:47:49 +0000 Original-Received: from localhost ([127.0.0.1]:54208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dT3O0-0005Df-Oj for submit@debbugs.gnu.org; Thu, 06 Jul 2017 05:47:48 -0400 Original-Received: from starfish.geekisp.com ([216.168.135.166]:8102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dT3Nz-0005DR-3T for 16377@debbugs.gnu.org; Thu, 06 Jul 2017 05:47:47 -0400 Original-Received: (qmail 22862 invoked by uid 1003); 6 Jul 2017 09:47:40 -0000 Original-Received: from unknown (HELO marvin.localdomain) (toby@dr-qubit.org@128.16.15.253) by mail.geekisp.com with (DHE-RSA-AES256-SHA encrypted) SMTP; 6 Jul 2017 09:47:40 -0000 Original-Received: by marvin.localdomain (Postfix, from userid 1000) id 7D57A2C5927B; Thu, 6 Jul 2017 10:47:39 +0100 (BST) Content-Disposition: inline In-Reply-To: <20170706090256.GA20017@marvin.cs.ucl.ac.uk> X-PGP-Key: http://www.dr-qubit.org/gpg-toby-pub.asc X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134253 Archived-At: On Thu, Jul 06, 2017 at 10:02:56AM +0100, Toby Cubitt wrote: > I'm way behind on dealing with undo-tree bug reports whilst busy with > "real life". #16377 is a very helpful bug report, which I can now > reproduce much more reliably with current Emacs version than I could when > it was originally reported. I hope to have time for a mammoth undo-tree > maintenance session later this summer. If that works out, I'll look into > it then. Scratch that. I can't reproduce #16377 in Emacs 25.2.1, undo-tree git head, except by calling undo-tree-undo/redo commands via M-x in buffers where undo-tree-mode is disabled. Calling undo-tree commands with undo-tree-mode disabled is entirely expected to mess up buffer-undo-list. I've added checks in git to all the undo-tree interactive commands to throw a user-error if they're called when undo-tree is not enabled, to guard against this. But that has nothing to do with the original bug, which appears to already be fixed in git. Toby -- Dr T. S. Cubitt Royal Society University Research Fellow Quantum Information Theory Department of Computer Science University College London email: tsc25@cantab.net web: www.dr-qubit.org