From: Alan Modra <amodra@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 20614@debbugs.gnu.org
Subject: bug#20614: alignment problem with recent Emacs unexelf.c changes
Date: Tue, 17 Nov 2015 19:33:04 +1030 [thread overview]
Message-ID: <20151117090304.GE8120@bubble.grove.modra.org> (raw)
In-Reply-To: <564A89FD.6080206@cs.ucla.edu>
On Mon, Nov 16, 2015 at 05:59:25PM -0800, Paul Eggert wrote:
> I ran into a porting problem when using Emacs's recent unexelf.c changes in
> a picky build using GCC’s -fsanitize=undefined option. The attached patch
> worked for me, so I installed it into emacs-25. Alan, could you please check
> and/or improve this patch, and/or think about whether there might be similar
> problems elsewhere? Thanks.
The patch looks good to me, and yes, section headers ought to be
aligned to their natural alignment (4 byte for 32-bit object files,
8 byte for 64-bit objects). .symtab should be kept aligned too, and
your patch accomplishes that as well. Thanks for fixing this. No
other alignment requirements come to mind.
Note that the new unexelf.c does not handle objects using .lrodata,
.ldata and .lbss or other "large sections" typically loaded well above
.bss in the address space. The old unexelf.c didn't handle them
properly either..
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2015-11-17 9:03 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 7:56 bug#20614: Segmentation fault when building on Power8 Little Endian Petr Hracek
2015-05-20 14:45 ` Eli Zaretskii
2015-05-20 16:12 ` Glenn Morris
2015-05-21 12:55 ` Petr Hracek
2015-07-13 11:27 ` Petr Hracek
2015-07-13 13:16 ` Andreas Schwab
2015-07-14 7:52 ` Petr Hracek
2015-07-14 8:14 ` Andreas Schwab
2015-09-16 11:28 ` Petr Hracek
2015-09-22 10:17 ` Petr Hracek
2015-09-23 8:06 ` Petr Hracek
2015-09-23 9:34 ` Eli Zaretskii
2015-09-23 11:00 ` Petr Hracek
2015-09-23 11:14 ` Eli Zaretskii
2015-09-23 12:11 ` Petr Hracek
2015-09-23 12:23 ` Eli Zaretskii
2015-09-24 11:04 ` Petr Hracek
2015-09-24 15:32 ` Eli Zaretskii
2015-09-24 17:56 ` Petr Hracek
2015-09-26 7:58 ` Eli Zaretskii
2015-09-30 10:39 ` Petr Hracek
2015-10-01 7:43 ` Eli Zaretskii
2015-10-01 8:46 ` Petr Hracek
2015-10-01 11:44 ` Petr Hracek
2015-10-01 11:53 ` Petr Hracek
2015-10-01 12:22 ` Eli Zaretskii
2015-10-01 14:05 ` Petr Hracek
2015-10-01 16:01 ` Eli Zaretskii
2015-10-02 8:36 ` Petr Hracek
2015-10-02 8:49 ` Eli Zaretskii
2015-10-02 12:58 ` Petr Hracek
2015-10-02 13:46 ` Eli Zaretskii
2015-10-05 7:40 ` Petr Hracek
2015-10-05 8:27 ` Eli Zaretskii
2015-10-05 9:16 ` Petr Hracek
2015-10-05 9:39 ` Eli Zaretskii
2015-10-05 11:23 ` Petr Hracek
2015-10-05 11:40 ` Eli Zaretskii
2015-10-05 14:07 ` Petr Hracek
2015-10-05 16:52 ` Eli Zaretskii
2015-10-06 8:41 ` Petr Hracek
2015-10-06 11:52 ` Petr Hracek
2015-10-06 14:55 ` Eli Zaretskii
2015-10-07 8:17 ` Petr Hracek
2015-10-07 10:56 ` YAMAMOTO Mitsuharu
2015-10-07 12:26 ` Petr Hracek
2015-10-08 0:54 ` YAMAMOTO Mitsuharu
2015-10-08 13:27 ` Jaromir Capik
2015-10-10 1:40 ` YAMAMOTO Mitsuharu
2015-10-10 15:44 ` Andreas Schwab
2015-10-13 7:30 ` Petr Hracek
2015-10-13 8:30 ` Andreas Schwab
2015-10-16 15:24 ` Jaromir Capik
2015-10-19 7:20 ` Andreas Schwab
2015-09-23 12:10 ` Petr Hracek
2015-09-23 12:21 ` Eli Zaretskii
2015-09-23 13:10 ` Petr Hracek
2015-09-23 13:38 ` Petr Hracek
2015-09-23 13:57 ` Eli Zaretskii
2015-09-23 17:25 ` Glenn Morris
2015-09-23 17:47 ` Glenn Morris
2015-09-29 8:15 ` Florian Weimer
2015-07-13 12:17 ` bug#20614: Segmentation fault when building on Power8 Little Endian (ppc64le) Petr Hracek
2015-11-17 1:59 ` bug#20614: alignment problem with recent Emacs unexelf.c changes Paul Eggert
2015-11-17 9:03 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117090304.GE8120@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=20614@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).