From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Modra Newsgroups: gmane.emacs.bugs Subject: bug#20614: alignment problem with recent Emacs unexelf.c changes Date: Tue, 17 Nov 2015 19:33:04 +1030 Message-ID: <20151117090304.GE8120@bubble.grove.modra.org> References: <564A89FD.6080206@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1447782214 24926 80.91.229.3 (17 Nov 2015 17:43:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Nov 2015 17:43:34 +0000 (UTC) Cc: 20614@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 17 18:43:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZykHp-0002uQ-NZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Nov 2015 18:43:21 +0100 Original-Received: from localhost ([::1]:59980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZykHp-0006hR-6y for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Nov 2015 12:43:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZykHb-0006WY-BE for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 12:43:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZykHW-0006L1-5y for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 12:43:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZykHW-0006Kj-39 for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 12:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZykHV-0005fw-Qe for bug-gnu-emacs@gnu.org; Tue, 17 Nov 2015 12:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Modra Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Nov 2015 17:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20614 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20614-submit@debbugs.gnu.org id=B20614.144778217921801 (code B ref 20614); Tue, 17 Nov 2015 17:43:01 +0000 Original-Received: (at 20614) by debbugs.gnu.org; 17 Nov 2015 17:42:59 +0000 Original-Received: from localhost ([127.0.0.1]:41975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZykHS-0005fX-KM for submit@debbugs.gnu.org; Tue, 17 Nov 2015 12:42:58 -0500 Original-Received: from mail-pa0-f48.google.com ([209.85.220.48]:35328) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZycAQ-0005mi-W2 for 20614@debbugs.gnu.org; Tue, 17 Nov 2015 04:03:29 -0500 Original-Received: by pacej9 with SMTP id ej9so3018659pac.2 for <20614@debbugs.gnu.org>; Tue, 17 Nov 2015 01:03:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GhPJiNv8wuMG18LjC5gUbEdJ1jTDZehKPxgkH46tFQ0=; b=DjSraewiCzNmm3vq0D9lMtlQ1YOFzODckLXl7h3us5UHbSDzxph462vDQpmUYhQmeD TedTxf5A8tmmUtG4Rx13z+eRR0tA8si9OZ7aqeTjBekLZqa8aAmwPQCdRLD2EcFGnSwe E+2LtwA3w3/QwZhEkCKvhOgzsay24gcFdhoH5aUIwf7dgh/JBDA5PYb895/EYejdVRpI 7/biQFwGYbi1twGZN3MyKzGiBR15UCrlykjlKfIJMo8Wi3y4eS357L1ya2ItPznbIDe/ thbs9tckUS6Tecn5W1v92ezvCLMSHa6z6sahXB2z0D8LWULfw1DYmhQrkYf22AKZtk7f +/LQ== X-Received: by 10.66.97.8 with SMTP id dw8mr60849779pab.113.1447750990207; Tue, 17 Nov 2015 01:03:10 -0800 (PST) Original-Received: from bubble.grove.modra.org (CPE-58-160-163-67.gqzg1.fli.bigpond.net.au. [58.160.163.67]) by smtp.gmail.com with ESMTPSA id fx3sm41355836pbb.60.2015.11.17.01.03.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2015 01:03:09 -0800 (PST) Original-Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 79581EA0109; Tue, 17 Nov 2015 19:33:04 +1030 (ACDT) Content-Disposition: inline In-Reply-To: <564A89FD.6080206@cs.ucla.edu> User-Agent: Mutt/1.5.23 (2014-03-12) X-Mailman-Approved-At: Tue, 17 Nov 2015 12:42:57 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108832 Archived-At: On Mon, Nov 16, 2015 at 05:59:25PM -0800, Paul Eggert wrote: > I ran into a porting problem when using Emacs's recent unexelf.c changes in > a picky build using GCC’s -fsanitize=undefined option. The attached patch > worked for me, so I installed it into emacs-25. Alan, could you please check > and/or improve this patch, and/or think about whether there might be similar > problems elsewhere? Thanks. The patch looks good to me, and yes, section headers ought to be aligned to their natural alignment (4 byte for 32-bit object files, 8 byte for 64-bit objects). .symtab should be kept aligned too, and your patch accomplishes that as well. Thanks for fixing this. No other alignment requirements come to mind. Note that the new unexelf.c does not handle objects using .lrodata, .ldata and .lbss or other "large sections" typically loaded well above .bss in the address space. The old unexelf.c didn't handle them properly either.. -- Alan Modra Australia Development Lab, IBM