* bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func
@ 2012-06-13 17:35 Masatake YAMATO
2012-06-13 20:14 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Masatake YAMATO @ 2012-06-13 17:35 UTC (permalink / raw)
To: 11698
This is not a bug report.
This is a request for merging the attached patch
to the emacs official source tree.
See the patch.
The original code is written in 2004.
I implemented mouse-face on mode-line in 2005-06-07:)
2012-06-13 Masatake YAMATO <yamato@redhat.com>
* progmodes/which-func.el (which-func-format): Enable
mouse-face.
=== modified file 'lisp/progmodes/which-func.el'
*** lisp/progmodes/which-func.el 2012-06-03 11:10:44 +0000
--- lisp/progmodes/which-func.el 2012-06-13 17:20:38 +0000
***************
*** 144,150 ****
(:propertize which-func-current
local-map ,which-func-keymap
face which-func
! ;;mouse-face highlight ; currently not evaluated :-(
help-echo "mouse-1: go to beginning\n\
mouse-2: toggle rest visibility\n\
mouse-3: go to end")
--- 144,150 ----
(:propertize which-func-current
local-map ,which-func-keymap
face which-func
! mouse-face highlight
help-echo "mouse-1: go to beginning\n\
mouse-2: toggle rest visibility\n\
mouse-3: go to end")
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func
2012-06-13 17:35 bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func Masatake YAMATO
@ 2012-06-13 20:14 ` Glenn Morris
2012-06-14 3:01 ` Masatake YAMATO
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2012-06-13 20:14 UTC (permalink / raw)
To: Masatake YAMATO; +Cc: 11698
Masatake YAMATO wrote:
> ! mouse-face highlight
Is this really desirable? Many other parts of the mode line can be
clicked on, but do not have a mouse-face. Isn't the change in cursor
sufficient?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func
2012-06-13 20:14 ` Glenn Morris
@ 2012-06-14 3:01 ` Masatake YAMATO
2012-06-25 7:13 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Masatake YAMATO @ 2012-06-14 3:01 UTC (permalink / raw)
To: rgm; +Cc: 11698
Glenn Morris wrote:
> Masatake YAMATO wrote:
>
>> ! mouse-face highlight
>
> Is this really desirable? Many other parts of the mode line can be
> clicked on, but do not have a mouse-face. Isn't the change in cursor
> sufficient?
It seems that mode-line-highlight is used for mouse-face.
How do you think to use it in which-func for keeping consistency
between other area on the mode line?
I think sometimes cursor is not sufficient. It doesn't tells just the
pixel under the cursor is something clickable. The feed-back with
mouse-face can tell the area under the cursor is something
clickable. Sometimes it is obvious that the area even without mouse
face. However, it may be a bit difficult to recognize one-character
area like area for buffer-coding system.
=== modified file 'lisp/progmodes/which-func.el'
*** lisp/progmodes/which-func.el 2012-06-03 11:10:44 +0000
--- lisp/progmodes/which-func.el 2012-06-14 02:55:51 +0000
***************
*** 144,150 ****
(:propertize which-func-current
local-map ,which-func-keymap
face which-func
! ;;mouse-face highlight ; currently not evaluated :-(
help-echo "mouse-1: go to beginning\n\
mouse-2: toggle rest visibility\n\
mouse-3: go to end")
--- 144,150 ----
(:propertize which-func-current
local-map ,which-func-keymap
face which-func
! mouse-face mode-line-highlight
help-echo "mouse-1: go to beginning\n\
mouse-2: toggle rest visibility\n\
mouse-3: go to end")
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func
2012-06-14 3:01 ` Masatake YAMATO
@ 2012-06-25 7:13 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2012-06-25 7:13 UTC (permalink / raw)
To: 11698-done
Version: 24.2
Masatake YAMATO wrote:
> ! mouse-face mode-line-highlight
Applied to emacs-24 branch, thanks. (I hadn't appreciated that
mode-line-highlight is already used all over the place in the mode-line.)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-25 7:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-13 17:35 bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func Masatake YAMATO
2012-06-13 20:14 ` Glenn Morris
2012-06-14 3:01 ` Masatake YAMATO
2012-06-25 7:13 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).