bug#4653: 23.1.50; ordering of bookmark-jump menu

bug#4653: 23.1.50; ordering of bookmark-jump menu

[Markus Rost]

If you call

C-x r l  (bookmark-bmenu-list)

the list of bookmarks is ordered by name.  Similarly with C-x r b RET.
That is fine.

However, if you call bookmark-jump through the menu, with

<menu-bar> <edit> <bookmark> <jump>

the shown list (in a pop up window) has the order from .emacs.bmk.
That wasn't the case with Emacs 22.

bug#4653: 23.1.50; ordering of bookmark-jump menu

[Markus Rost]

Sorry, that *was* the case with Emacs 22 as well.  In my private copy
of Emacs 22 I had applied the patch below (I have added 'bookmark-jump
to the tool-bar and I use the menu very often).

A change like in the patch seems to be more consistent with the
documentation of bookmark-sort-flag:

Non-nil means that bookmarks will be displayed sorted by bookmark name.


*** lisp/bookmark.el.~1~	2008-01-07 03:45:03.000000000 +0100
--- lisp/bookmark.el	2009-01-22 02:28:54.000000000 +0100
***************
*** 460,466 ****
  the empty string."
    (bookmark-maybe-load-default-file) ; paranoia
    (if (listp last-nonmenu-event)
!       (bookmark-menu-popup-paned-menu t prompt (bookmark-all-names))
      (let* ((completion-ignore-case bookmark-completion-ignore-case)
  	   (default default)
  	   (prompt (if default
--- 460,470 ----
  the empty string."
    (bookmark-maybe-load-default-file) ; paranoia
    (if (listp last-nonmenu-event)
!       (bookmark-menu-popup-paned-menu t prompt
! 				      (if bookmark-sort-flag
! 					  (sort (bookmark-all-names)
! 						'string-lessp)
! 					(bookmark-all-names)))
      (let* ((completion-ignore-case bookmark-completion-ignore-case)
  	   (default default)
  	   (prompt (if default

bug#4653: marked as done (23.1.50; ordering of bookmark-jump menu)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

Your message dated Sun, 08 Nov 2009 18:02:30 -0500
with message-id <87iqdkk4c9.fsf@stupidchicken.com>
and subject line Re: bug#4653: 23.1.50; ordering of bookmark-jump menu
has caused the Emacs bug report #4653,
regarding 23.1.50; ordering of bookmark-jump menu
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4653: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4653
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2410 bytes --]

From: Markus Rost <rost@math.uni-bielefeld.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.1.50; ordering of bookmark-jump menu
Date: Tue,  6 Oct 2009 16:29:40 +0200 (CEST)
Message-ID: <20091006142940.D8111EFE6F@sonic02.math.uni-bielefeld.de>

If you call

C-x r l  (bookmark-bmenu-list)

the list of bookmarks is ordered by name.  Similarly with C-x r b RET.
That is fine.

However, if you call bookmark-jump through the menu, with

<menu-bar> <edit> <bookmark> <jump>

the shown list (in a pop up window) has the order from .emacs.bmk.
That wasn't the case with Emacs 22.


[-- Attachment #3: Type: message/rfc822, Size: 1831 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Markus Rost <rost@math.uni-bielefeld.de>
Cc: 4653-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4653: 23.1.50; ordering of bookmark-jump menu
Date: Sun, 08 Nov 2009 18:02:30 -0500
Message-ID: <87iqdkk4c9.fsf@stupidchicken.com>

> Sorry, that *was* the case with Emacs 22 as well.  In my private copy
> of Emacs 22 I had applied the patch below (I have added 'bookmark-jump
> to the tool-bar and I use the menu very often).
>
> A change like in the patch seems to be more consistent with the
> documentation of bookmark-sort-flag

Look reasonable.  I've checked the patch in, thank you.