* bug#2349: 23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region
@ 2009-02-16 21:25 ` Xavier Maillard
2009-12-11 1:30 ` bug#2349: marked as done (23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region) Emacs bug Tracking System
0 siblings, 1 reply; 3+ messages in thread
From: Xavier Maillard @ 2009-02-16 21:25 UTC (permalink / raw)
To: emacs-pretest-bug
I think there is no need to let user modify the region going from
user report text to recent keys, thus I think we could extend the
sticky property to that region.
Users still can modify recent keys section (to hide security
details for example).
Here is the proposed patch:
diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index 7132da6..6dd7a6c 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -145,7 +145,6 @@ usually do not have translators to read other languages for them.\n\n")
(if (file-readable-p debug-file)
(insert "If you would like to further debug the crash, please read the file\n"
debug-file " for instructions.\n")))
- (add-text-properties (1+ user-point) (point) prompt-properties)
(insert "\n\nIn " (emacs-version) "\n")
(if (fboundp 'x-server-vendor)
@@ -180,6 +179,8 @@ usually do not have translators to read other languages for them.\n\n")
(insert (format " %s: %s\n" mode
(buffer-local-value mode from-buffer)))))
(insert "\n")
+ (add-text-properties (1+ user-point) (point) prompt-properties)
+
(insert "Recent input:\n")
(let ((before-keys (point)))
(insert (mapconcat (lambda (key)
With this proposed ChangeLog entry:
2009-02-16 Xavier Maillard <xma@gnu.org>
* mail/emacsbug.el.new (report-emacs-bug): Extend stickiness
property to major and minor modes section.
Recent input:
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> t o SPC M a j o <backspace> <backspace>
<backspace> <backspace> m a j o r SPC a n d SPC m i
n o r SPC m o d e s SPC d e t e c t i o n . C-x C-w
C h a n <tab> <tab> . n e w <return> M-x e d i f f
- d i <tab> i <tab> <return> m a i l <return> <up>
<return> <return> M-x <up> C-e <backspace> <backspace>
<backspace> <backspace> C-g M-x e d i <tab> f f <return>
<return> <up> <backspace> <backspace> <backspace> <backspace>
<return> ? D <switch-frame> <down> <up> <down> <down>
<down> <down> D <switch-frame> C-x o C-x 1 M-x d i
f f <tab> <tab> - e d <tab> <return> C-g M-x <up> C-e
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <tab> b u f f <tab> <return> <return> q
C-x C-w C C-g M-k M-k M-k C-x C-w e m a c s b u <tab>
<return> y M-x <up> <return> <return> q M-x v c - d
i f <tab> <return> c M-x d i f f - u n i <tab> <return>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> q <down> = <backspace>
<backspace> M-x <up> <return> M-x <up> <up> <up> <return>
<return> c M-x <up> <up> <return> q C-x C-s M-x g i
t <backspace> <backspace> <backspace> C-g M-x <up>
<up> <up> <return> C-x h M-w M-x r e p o r t <tab>
<return>
Recent messages:
Saving file /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...
Wrote /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el
Finding changes in /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...done
Buffer is read-only: #<buffer *vc-diff*>
Buffer is read-only: #<buffer *Diff*>
Saving file /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...
Wrote /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el
Quit
Finding changes in /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...done
Mark set [2 times]
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#2349: 23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region
@ 2009-03-02 1:25 Xavier Maillard
0 siblings, 0 replies; 3+ messages in thread
From: Xavier Maillard @ 2009-03-02 1:25 UTC (permalink / raw)
To: 2349; +Cc: emacs-pretest-bug
There was a typo in the proposed ChangeLog entry. Here is the
correct one.
2009-02-16 Xavier Maillard <xma@gnu.org>
* mail/emacsbug.el (report-emacs-bug): Extend stickiness
properties to major and minor modes detection.
Regards
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#2349: marked as done (23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region)
2009-02-16 21:25 ` bug#2349: 23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region Xavier Maillard
@ 2009-12-11 1:30 ` Emacs bug Tracking System
0 siblings, 0 replies; 3+ messages in thread
From: Emacs bug Tracking System @ 2009-12-11 1:30 UTC (permalink / raw)
To: Glenn Morris
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
Your message dated Thu, 10 Dec 2009 20:21:48 -0500
with message-id <i2r5r2gv9v.fsf@fencepost.gnu.org>
and subject line Re: Bug#2349: report-emacs-bug - extend stickyness property region
has caused the Emacs bug report #2349,
regarding 23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
2349: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2349
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 6212 bytes --]
From: Xavier Maillard <xma@gnu.org>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region
Date: Mon, 16 Feb 2009 22:25:02 +0100
Message-ID: <200902162125.n1GLP2Vm002839@zogzog.maillard.mobi>
I think there is no need to let user modify the region going from
user report text to recent keys, thus I think we could extend the
sticky property to that region.
Users still can modify recent keys section (to hide security
details for example).
Here is the proposed patch:
diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index 7132da6..6dd7a6c 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -145,7 +145,6 @@ usually do not have translators to read other languages for them.\n\n")
(if (file-readable-p debug-file)
(insert "If you would like to further debug the crash, please read the file\n"
debug-file " for instructions.\n")))
- (add-text-properties (1+ user-point) (point) prompt-properties)
(insert "\n\nIn " (emacs-version) "\n")
(if (fboundp 'x-server-vendor)
@@ -180,6 +179,8 @@ usually do not have translators to read other languages for them.\n\n")
(insert (format " %s: %s\n" mode
(buffer-local-value mode from-buffer)))))
(insert "\n")
+ (add-text-properties (1+ user-point) (point) prompt-properties)
+
(insert "Recent input:\n")
(let ((before-keys (point)))
(insert (mapconcat (lambda (key)
With this proposed ChangeLog entry:
2009-02-16 Xavier Maillard <xma@gnu.org>
* mail/emacsbug.el.new (report-emacs-bug): Extend stickiness
property to major and minor modes section.
Recent input:
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> t o SPC M a j o <backspace> <backspace>
<backspace> <backspace> m a j o r SPC a n d SPC m i
n o r SPC m o d e s SPC d e t e c t i o n . C-x C-w
C h a n <tab> <tab> . n e w <return> M-x e d i f f
- d i <tab> i <tab> <return> m a i l <return> <up>
<return> <return> M-x <up> C-e <backspace> <backspace>
<backspace> <backspace> C-g M-x e d i <tab> f f <return>
<return> <up> <backspace> <backspace> <backspace> <backspace>
<return> ? D <switch-frame> <down> <up> <down> <down>
<down> <down> D <switch-frame> C-x o C-x 1 M-x d i
f f <tab> <tab> - e d <tab> <return> C-g M-x <up> C-e
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <tab> b u f f <tab> <return> <return> q
C-x C-w C C-g M-k M-k M-k C-x C-w e m a c s b u <tab>
<return> y M-x <up> <return> <return> q M-x v c - d
i f <tab> <return> c M-x d i f f - u n i <tab> <return>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> q <down> = <backspace>
<backspace> M-x <up> <return> M-x <up> <up> <up> <return>
<return> c M-x <up> <up> <return> q C-x C-s M-x g i
t <backspace> <backspace> <backspace> C-g M-x <up>
<up> <up> <return> C-x h M-w M-x r e p o r t <tab>
<return>
Recent messages:
Saving file /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...
Wrote /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el
Finding changes in /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...done
Buffer is read-only: #<buffer *vc-diff*>
Buffer is read-only: #<buffer *Diff*>
Saving file /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...
Wrote /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el
Quit
Finding changes in /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...done
Mark set [2 times]
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
[-- Attachment #3: Type: message/rfc822, Size: 1679 bytes --]
From: Glenn Morris <rgm@gnu.org>
To: 2349-done@emacsbugs.donarmstrong.com
Subject: Re: Bug#2349: report-emacs-bug - extend stickyness property region
Date: Thu, 10 Dec 2009 20:21:48 -0500
Message-ID: <i2r5r2gv9v.fsf@fencepost.gnu.org>
Thanks for the patch, but it isn't appropriate. The propertized
regions are just used to mark non-interesting boilerplate text that is
automatically stripped before sending the bug report. These regions
should not be extended to cover potentially useful data.
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-11 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <i2r5r2gv9v.fsf@fencepost.gnu.org>
2009-02-16 21:25 ` bug#2349: 23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region Xavier Maillard
2009-12-11 1:30 ` bug#2349: marked as done (23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region) Emacs bug Tracking System
2009-03-02 1:25 bug#2349: 23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region Xavier Maillard
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).