unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Torsten Bronger <bronger@physik.rwth-aachen.de>
Cc: 2157@emacsbugs.donarmstrong.com
Subject: bug#2157: 23.0.90; bzr support: vc-diff doesn't work with prefix argument on unchanged files
Date: Tue, 3 Feb 2009 23:43:33 -0800 (PST)	[thread overview]
Message-ID: <200902040743.n147hXNJ010731@rodan.ics.uci.edu> (raw)
In-Reply-To: <87eiygezvn.fsf@physik.rwth-aachen.de> (Torsten Bronger's message of "Tue, 03 Feb 2009 08:35:56 +0100")

Torsten Bronger <bronger@physik.rwth-aachen.de> writes:

  > Hallöchen!
  > 
  > Dan Nicolaescu writes:
  > 
  > > Torsten Bronger <bronger@physik.rwth-aachen.de> writes:
  > >
  > >> Dan Nicolaescu writes:
  > >> 
  > >>> Torsten Bronger <bronger@physik.rwth-aachen.de> writes:
  > >>>
  > >>>> If I visit an unchanged file under bzr revision control,
  > >>>> i.e. the modeline says "Bzr-" (NOT "Bzr:"), I can't use C-u C-x
  > >>>> v =, i.e. vc-diff but with explicit revision parameters.  The
  > >>>> error message is:
  > >>>> 
  > >>>> vc-bzr-previous-revision: Wrong type argument: stringp, nil
  > >
  > > [...]
  > >
  > > This shows that (vc-working-revision
  > > "/home/bronger/src/chantal/current/chantal/samples/remote_client/la2chantal.py")
  > >
  > > returns nil.  So probably for some reason
  > > (vc-bzr-working-revision
  > > "/home/bronger/src/chantal/current/chantal/samples/remote_client/la2chantal.py")
  > >
  > > returns nil.  Can you try to debug why that happens?
  > 
  > I don't know Lisp, but I hooked into the bzr executable and can
  > safely say that it isn't called for this action.  So apparently,
  > vc-bzr-working-revision tries to get the revno from the metadata in
  > the .bzr/ directory.  The branch format is "Bazaar Branch Format 7
  > (needs bzr 1.6)".

Thanks, I checked in a fix for that.

  > By the way, bug#618 is probably related to this.  Formerly, I had
  > missing revno in the modeline only in lightweight checkout, now I
  > have the same problem with all branches.  Maybe the branch metadata
  > format has diverged too much for vc-bzr?

Is this still a problem now?  If it is and you can describe how to get a
"lightweight checkout", it might be easy to fix.
If you want to look into this yourself, vc-bzr-working-revision is the
function that should get the version number.






  reply	other threads:[~2009-02-04  7:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200903231626.n2NGQlXn010786@godzilla.ics.uci.edu>
2009-02-02 10:04 ` bug#2157: 23.0.90; bzr support: vc-diff doesn't work with prefix argument on unchanged files Torsten Bronger
2009-02-02 20:05   ` Dan Nicolaescu
2009-02-02 20:37     ` Torsten Bronger
2009-02-02 22:37       ` Dan Nicolaescu
2009-02-03  7:35         ` Torsten Bronger
2009-02-04  7:43           ` Dan Nicolaescu [this message]
2009-02-04  8:31             ` Torsten Bronger
2009-02-04 15:48               ` Dan Nicolaescu
2009-02-04 17:09                 ` Torsten Bronger
2009-02-03  7:48         ` Torsten Bronger
2009-03-23 16:35   ` bug#2157: marked as done (23.0.90; bzr support: vc-diff doesn't work with prefix argument on unchanged files) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902040743.n147hXNJ010731@rodan.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=2157@emacsbugs.donarmstrong.com \
    --cc=bronger@physik.rwth-aachen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).