From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#2157: 23.0.90; bzr support: vc-diff doesn't work with prefix argument on unchanged files Date: Tue, 3 Feb 2009 23:43:33 -0800 (PST) Message-ID: <200902040743.n147hXNJ010731@rodan.ics.uci.edu> References: <20090202100449.B94A5E4057@wilson.homeunix.com> <200902022005.n12K5jIx023982@rodan.ics.uci.edu> <87fxiwa83w.fsf@physik.rwth-aachen.de> <200902022237.n12MbtsC025843@rodan.ics.uci.edu> <87eiygezvn.fsf@physik.rwth-aachen.de> Reply-To: Dan Nicolaescu , 2157@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1233734697 10363 80.91.229.12 (4 Feb 2009 08:04:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2009 08:04:57 +0000 (UTC) Cc: 2157@emacsbugs.donarmstrong.com To: Torsten Bronger Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 04 09:06:11 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUclC-00073r-IL for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2009 09:05:52 +0100 Original-Received: from localhost ([127.0.0.1]:57393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUcjt-0005vb-H2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2009 03:04:05 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUcjT-0005k0-0E for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 03:03:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUcjR-0005jO-8h for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 03:03:38 -0500 Original-Received: from [199.232.76.173] (port=43802 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUcjQ-0005jJ-Ug for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 03:03:36 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:39090) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUcjQ-0002c2-A1 for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 03:03:36 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LUcjN-0007ZA-OX for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 03:03:34 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1483V33004798; Wed, 4 Feb 2009 00:03:31 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n147o3Ol001332; Tue, 3 Feb 2009 23:50:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 04 Feb 2009 07:50:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2157 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2157-submit@emacsbugs.donarmstrong.com id=B2157.123373344932501 (code B ref 2157); Wed, 04 Feb 2009 07:50:03 +0000 Original-Received: (at 2157) by emacsbugs.donarmstrong.com; 4 Feb 2009 07:44:09 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n147i2DV032495 for <2157@emacsbugs.donarmstrong.com>; Tue, 3 Feb 2009 23:44:03 -0800 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n147hXpO008037; Tue, 3 Feb 2009 23:43:33 -0800 (PST) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n147hXNJ010731; Tue, 3 Feb 2009 23:43:33 -0800 (PST) In-Reply-To: <87eiygezvn.fsf@physik.rwth-aachen.de> (Torsten Bronger's message of "Tue, 03 Feb 2009 08:35:56 +0100") Original-Lines: 47 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n147hXpO008037 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Wed, 04 Feb 2009 03:03:37 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24919 Archived-At: Torsten Bronger writes: > Hall=C3=B6chen! >=20 > Dan Nicolaescu writes: >=20 > > Torsten Bronger writes: > > > >> Dan Nicolaescu writes: > >>=20 > >>> Torsten Bronger writes: > >>> > >>>> If I visit an unchanged file under bzr revision control, > >>>> i.e. the modeline says "Bzr-" (NOT "Bzr:"), I can't use C-u C-x > >>>> v =3D, i.e. vc-diff but with explicit revision parameters. The > >>>> error message is: > >>>>=20 > >>>> vc-bzr-previous-revision: Wrong type argument: stringp, nil > > > > [...] > > > > This shows that (vc-working-revision > > "/home/bronger/src/chantal/current/chantal/samples/remote_client/la2c= hantal.py") > > > > returns nil. So probably for some reason > > (vc-bzr-working-revision > > "/home/bronger/src/chantal/current/chantal/samples/remote_client/la2c= hantal.py") > > > > returns nil. Can you try to debug why that happens? >=20 > I don't know Lisp, but I hooked into the bzr executable and can > safely say that it isn't called for this action. So apparently, > vc-bzr-working-revision tries to get the revno from the metadata in > the .bzr/ directory. The branch format is "Bazaar Branch Format 7 > (needs bzr 1.6)". Thanks, I checked in a fix for that. > By the way, bug#618 is probably related to this. Formerly, I had > missing revno in the modeline only in lightweight checkout, now I > have the same problem with all branches. Maybe the branch metadata > format has diverged too much for vc-bzr? Is this still a problem now? If it is and you can describe how to get a "lightweight checkout", it might be easy to fix. If you want to look into this yourself, vc-bzr-working-revision is the function that should get the version number.