From: Dan Nicolaescu <dann@ics.uci.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 2136@emacsbugs.donarmstrong.com
Subject: bug#2136: cleanup: Fresume_tty and Fsuspend_tty
Date: Sat, 31 Jan 2009 19:43:44 -0800 (PST) [thread overview]
Message-ID: <200902010343.n113hirV018281@rodan.ics.uci.edu> (raw)
In-Reply-To: <uzlh7cf0w.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Feb 2009 00:00:15 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> > Date: Sat, 31 Jan 2009 13:22:16 -0800 (PST)
> > From: Dan Nicolaescu <dann@ics.uci.edu>
> > Cc: 2136@emacsbugs.donarmstrong.com
> >
> > Can you have multiple ttys in MSDOS?
>
> No, of course not. Not if by ``tty'' you mean an interactive
> terminal.
>
> > Otherwise suspend-frame won't call supend-tty.
>
> It can be tricked into doing that, since the test in controlling-tty-p
> is very naive.
Then the test needs to be improved...
> > > For resume-tty, I just invoked it directly.
> >
> > See above, this function only makes sens when using multiple ttys.
>
> If you mean the full functionality, then yes, I agree. However, since
> the current uses of these two functions are so few, I cannot yet say
> that having them not fboundp will or won't do harm for the DOS port.
> For now, they are more or less no-ops, which certainly doesn't do any
> harm, at least AFAICS.
It complicates the code, I just recently fixed in bug there, that's how
I run into this.
> On the other hand, keeping them out of the DOS build would mean the
> same #ifdef's will have to stay, just in different places, which won't
> make the sources more clean, IMO.
Given that the functions are no-ops for DOS, just to put an #ifndef
inside the body and make them just return Qnil, that way it's pretty
clear they are no-ops.
prev parent reply other threads:[~2009-02-01 3:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 18:46 bug#2136: cleanup: Fresume_tty and Fsuspend_tty Dan Nicolaescu
2009-01-31 20:09 ` Eli Zaretskii
2009-01-31 20:14 ` Dan Nicolaescu
2009-01-31 20:40 ` Eli Zaretskii
2009-01-31 21:08 ` Eli Zaretskii
2013-02-06 19:08 ` Glenn Morris
2009-01-31 21:22 ` Dan Nicolaescu
2009-01-31 22:00 ` Eli Zaretskii
2009-02-01 3:43 ` Dan Nicolaescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902010343.n113hirV018281@rodan.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=2136@emacsbugs.donarmstrong.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).