From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#2136: cleanup: Fresume_tty and Fsuspend_tty Date: Sat, 31 Jan 2009 19:43:44 -0800 (PST) Message-ID: <200902010343.n113hirV018281@rodan.ics.uci.edu> References: <200901311846.n0VIkjDJ011449@rodan.ics.uci.edu> <200901312014.n0VKEPJf012429@rodan.ics.uci.edu> <200901312122.n0VLMG9h013407@rodan.ics.uci.edu> Reply-To: Dan Nicolaescu , 2136@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233461077 30736 80.91.229.12 (1 Feb 2009 04:04:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Feb 2009 04:04:37 +0000 (UTC) Cc: 2136@emacsbugs.donarmstrong.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 01 05:05:49 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LTTZp-0004Fu-Dx for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Feb 2009 05:04:57 +0100 Original-Received: from localhost ([127.0.0.1]:35316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LTTYX-0002up-2z for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Jan 2009 23:03:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LTTYU-0002tz-4L for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2009 23:03:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LTTYT-0002tS-79 for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2009 23:03:33 -0500 Original-Received: from [199.232.76.173] (port=37698 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LTTYT-0002tJ-4T for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2009 23:03:33 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:39711) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LTTYS-0002dX-Dt for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2009 23:03:32 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1143VDL027081; Sat, 31 Jan 2009 20:03:31 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n113o3fo023607; Sat, 31 Jan 2009 19:50:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 01 Feb 2009 03:50:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2136 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2136-submit@emacsbugs.donarmstrong.com id=B2136.123345984022379 (code B ref 2136); Sun, 01 Feb 2009 03:50:03 +0000 Original-Received: (at 2136) by emacsbugs.donarmstrong.com; 1 Feb 2009 03:44:00 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n113hvub022373 for <2136@emacsbugs.donarmstrong.com>; Sat, 31 Jan 2009 19:43:58 -0800 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n113hiF3027502; Sat, 31 Jan 2009 19:43:44 -0800 (PST) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n113hirV018281; Sat, 31 Jan 2009 19:43:44 -0800 (PST) In-Reply-To: (Eli Zaretskii's message of "Sun, 01 Feb 2009 00:00:15 +0200") Original-Lines: 38 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n113hiF3027502 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 31 Jan 2009 23:03:33 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24789 Archived-At: Eli Zaretskii writes: > > Date: Sat, 31 Jan 2009 13:22:16 -0800 (PST) > > From: Dan Nicolaescu > > Cc: 2136@emacsbugs.donarmstrong.com > > > > Can you have multiple ttys in MSDOS? > > No, of course not. Not if by ``tty'' you mean an interactive > terminal. > > > Otherwise suspend-frame won't call supend-tty. > > It can be tricked into doing that, since the test in controlling-tty-p > is very naive. Then the test needs to be improved... > > > For resume-tty, I just invoked it directly. > > > > See above, this function only makes sens when using multiple ttys. > > If you mean the full functionality, then yes, I agree. However, since > the current uses of these two functions are so few, I cannot yet say > that having them not fboundp will or won't do harm for the DOS port. > For now, they are more or less no-ops, which certainly doesn't do any > harm, at least AFAICS. It complicates the code, I just recently fixed in bug there, that's how I run into this. > On the other hand, keeping them out of the DOS build would mean the > same #ifdef's will have to stay, just in different places, which won't > make the sources more clean, IMO. Given that the functions are no-ops for DOS, just to put an #ifndef inside the body and make them just return Qnil, that way it's pretty clear they are no-ops.