unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Vivien Mallet <Vivien.Mallet@inria.fr>
To: bug-gnu-emacs@gnu.org
Subject: bug#681: Wrong C++ indentation in batch mode
Date: Sat, 9 Aug 2008 17:26:22 +0200	[thread overview]
Message-ID: <200808091726.22907.Vivien.Mallet@inria.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]

	Hello,

	The indentation in C++ mode does not seem to work properly in batch mode with 
the following code (indented in interactive mode):
"""
template <class A, class B>
Derived<A, B>::Derived():
  Base<A,
       B>() // Problem: wrong indentation in batch mode.
{
}
"""

	Now, define the Lisp function:
(defun cpp_indent ()
  (c-set-style "gnu")
  (c++-mode)
  (indent-region (point-min) (point-max) ())
  (save-buffer)
  )
	And apply it the previous function. It will result in:
"""
template <class A, class B>
Derived<A, B>::Derived():
  Base<A,
  B>() // Problem: wrong indentation in batch mode.
{
}
"""
	which is inconsistent with the interactive and is not, I presume, the 
targeted result.
	I found the problem in Emacs 23.0.60.1 (emacs snapshot in Kubuntu 8.04) and 
in Emacs 22.1.3. It does not appear in Emacs 21.4.1 (Debian Etch).


	Just an unrelated note about the indentation. I found a difference between the 
two latest versions I mentioned and the version 21.4.1. This code (indented 
with Emacs 22+):
"""
template <class A, class B>
Derived0<A, B>::Derived0():
  Base<A, B>
  ()
{
}
"""
	is indented by Emacs 21.4.1 as
"""
template <class A, class B>
Derived0<A, B>::Derived0():
  Base<A, B>
()
{
}
"""
	I like the new indentation better, and I suppose it was an improvement 
introduced in the latest versions. I mention it, just in case...


	I attach three files:
- test.cxx: a file to be indented (but already well indented);
- test-wrong_indentation.cxx: test.cxx after indentation in batch mode with 
Emacs 22+;
- cpp_indent.lisp: the indentation function. Used in: "emacs -batch test.cxx -
l cpp_indent.lisp -f cpp_indent".


	Thank you for your great work,
	Vivien Mallet.

[-- Attachment #2: test-wrong_indentation.cxx --]
[-- Type: text/x-c++src, Size: 251 bytes --]

template <class A, class B>
Derived<A, B>::Derived():
  Base<A,
  B>() // Problem: wrong indentation in batch mode.
{
}


template <class A, class B>
Derived0<A, B>::Derived0():
  Base<A, B>
  () // Just a note: Emacs 21 did not indent like that.
{
}

[-- Attachment #3: test.cxx --]
[-- Type: text/x-c++src, Size: 256 bytes --]

template <class A, class B>
Derived<A, B>::Derived():
  Base<A,
       B>() // Problem: wrong indentation in batch mode.
{
}


template <class A, class B>
Derived0<A, B>::Derived0():
  Base<A, B>
  () // Just a note: Emacs 21 did not indent like that.
{
}

[-- Attachment #4: cpp_indent.lisp --]
[-- Type: text/plain, Size: 121 bytes --]

(defun cpp_indent ()
  (c-set-style "gnu")
  (c++-mode)
  (indent-region (point-min) (point-max) ())
  (save-buffer)
  )

             reply	other threads:[~2008-08-09 15:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-09 15:26 Vivien Mallet [this message]
2008-08-10 16:42 ` bug#681: Wrong C++ indentation in batch mode OFFICE ZERO
     [not found]   ` <handler.681.B681.12183870793367.ackinfo@emacsbugs.donarmstrong.com>
2008-08-10 17:10     ` bug#681: Info received (bug#681: Wrong C++ indentation in batch mode) OFFICE ZERO
     [not found]       ` <handler.681.B681.121838828710091.ackinfo@emacsbugs.donarmstrong.com>
2008-08-11  1:17         ` bug#681: Info received (bug#681: Info received (bug#681: Wrong C++ indentation in batch mode)) OFFICE ZERO
2008-08-10 17:01 ` bug#681: Wrong C++ indentation in batch mode OFFICE ZERO
     [not found]   ` <handler.681.B681.12183876726365.ackinfo@emacsbugs.donarmstrong.com>
2008-08-11  1:17     ` bug#681: Info received (bug#681: Wrong C++ indentation in batch mode) OFFICE ZERO
2008-08-10 17:11 ` bug#681: Wrong C++ indentation in batch mode OFFICE ZERO
     [not found]   ` <handler.681.B681.121838833410165.ackinfo@emacsbugs.donarmstrong.com>
2008-08-11  1:16     ` bug#681: Info received (bug#681: Wrong C++ indentation in batch mode) OFFICE ZERO
2008-08-10 17:12 ` bug#681: Wrong C++ indentation in batch mode OFFICE ZERO
     [not found]   ` <handler.681.B681.121838833410168.ackinfo@emacsbugs.donarmstrong.com>
2008-08-11  1:07     ` bug#681: Info received (bug#681: Wrong C++ indentation in batch mode) OFFICE ZERO
2014-01-07 10:26 ` bug#681: Wrong C++ indentation in batch mode Bastien Guerry
2014-01-07 15:36   ` Vivien Mallet
2014-01-07 16:09     ` Bastien
2015-12-29  1:18       ` Andrew Hyatt
2015-12-29 22:02         ` Alan Mackenzie
2016-01-04 23:16         ` Alan Mackenzie
2016-01-26  4:46           ` Andrew Hyatt
2016-02-06 12:05           ` Vivien Mallet
2016-02-07 22:09             ` Alan Mackenzie
2016-02-07 22:10               ` Vivien Mallet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808091726.22907.Vivien.Mallet@inria.fr \
    --to=vivien.mallet@inria.fr \
    --cc=681@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).