unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#3928: changes to compilation-mode
@ 2009-10-12 19:34 Glenn Morris
  2009-10-12 21:06 ` Sam Steingold
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2009-10-12 19:34 UTC (permalink / raw)
  To: Sam Steingold; +Cc: 3928


Hi. This change:

2009-07-10  Sam Steingold  <sds at gnu.org>

   * progmodes/compile.el (compilation-mode-font-lock-keywords): Omake
   sometimes indents the errors it prints, so allow all regexps to
   start with spaces.

seems to cause issues with several of the existing compilation error
regexps.

See

http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3928

Please could you comment on / fix this?

I think it would be better not to have to change a bunch of the
existing regexps.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#3928: changes to compilation-mode
  2009-10-12 19:34 bug#3928: changes to compilation-mode Glenn Morris
@ 2009-10-12 21:06 ` Sam Steingold
  2009-10-13  1:02   ` Glenn Morris
  0 siblings, 1 reply; 4+ messages in thread
From: Sam Steingold @ 2009-10-12 21:06 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 3928

Hi, I fixed this in the CVS.
Sorry about the problem.

-- 
Sam Steingold <http://sds.podval.org>





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#3928: changes to compilation-mode
  2009-10-12 21:06 ` Sam Steingold
@ 2009-10-13  1:02   ` Glenn Morris
  2009-10-13  2:59     ` Sam Steingold
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2009-10-13  1:02 UTC (permalink / raw)
  To: Sam Steingold; +Cc: 3928

Sam Steingold wrote:

> Hi, I fixed this in the CVS.

Thanks. In:

(= ?* (aref pat 1))

I guess it is supposed to be `(aref pat 2)'?





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#3928: changes to compilation-mode
  2009-10-13  1:02   ` Glenn Morris
@ 2009-10-13  2:59     ` Sam Steingold
  0 siblings, 0 replies; 4+ messages in thread
From: Sam Steingold @ 2009-10-13  2:59 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 3928

On Mon, Oct 12, 2009 at 9:02 PM, Glenn Morris <rgm@gnu.org> wrote:
>
> (= ?* (aref pat 1))
>
> I guess it is supposed to be `(aref pat 2)'?

oops. fixed. sorry.


-- 
Sam Steingold <http://sds.podval.org>





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-10-13  2:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-12 19:34 bug#3928: changes to compilation-mode Glenn Morris
2009-10-12 21:06 ` Sam Steingold
2009-10-13  1:02   ` Glenn Morris
2009-10-13  2:59     ` Sam Steingold

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).