* bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap are not listed
@ 2022-12-15 14:49 Daniel Mendler
2022-12-17 12:53 ` Eli Zaretskii
2023-09-06 9:14 ` Stefan Kangas
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Mendler @ 2022-12-15 14:49 UTC (permalink / raw)
To: 60093
Keymaps defined via `defvar-keymap' are not available in the Imenu. It is
necessary to extend `imenu-generic-expression'.
In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw scroll bars) of 2022-12-11 built on projects
Repository revision: f221105723dc8d3ee9f3c8d1c2717058afbc6666
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap are not listed
2022-12-15 14:49 bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap are not listed Daniel Mendler
@ 2022-12-17 12:53 ` Eli Zaretskii
2022-12-19 9:54 ` Daniel Mendler
2023-09-06 9:14 ` Stefan Kangas
1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2022-12-17 12:53 UTC (permalink / raw)
To: Daniel Mendler; +Cc: 60093
> From: Daniel Mendler <mail@daniel-mendler.de>
> Date: Thu, 15 Dec 2022 15:49:31 +0100
>
> Keymaps defined via `defvar-keymap' are not available in the Imenu. It is
> necessary to extend `imenu-generic-expression'.
Thanks. Would you like to suggest a patch to fix this?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap are not listed
2022-12-17 12:53 ` Eli Zaretskii
@ 2022-12-19 9:54 ` Daniel Mendler
2022-12-19 12:46 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Mendler @ 2022-12-19 9:54 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 60093
On 12/17/22 13:53, Eli Zaretskii wrote:
>> From: Daniel Mendler <mail@daniel-mendler.de>
>> Date: Thu, 15 Dec 2022 15:49:31 +0100
>>
>> Keymaps defined via `defvar-keymap' are not available in the Imenu. It is
>> necessary to extend `imenu-generic-expression'.
>
> Thanks. Would you like to suggest a patch to fix this?
I don't have a patch ready. Currently I use the following line in my
configuration which also recognizes Embark keymaps. Would we want to
list keymaps as a separate Imenu category "Keymaps" or as "Variables"?
(add-to-list 'imenu-generic-expression '("Keymaps"
"^[^;]*(\\(?:embark-define-keymap\\|defvar-keymap\\)\\s-+\\(\\(?:\\sw\\|\\s_\\)+\\)"
1) 'append))))
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap are not listed
2022-12-19 9:54 ` Daniel Mendler
@ 2022-12-19 12:46 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2022-12-19 12:46 UTC (permalink / raw)
To: Daniel Mendler; +Cc: 60093
> Date: Mon, 19 Dec 2022 10:54:27 +0100
> Cc: 60093@debbugs.gnu.org
> From: Daniel Mendler <mail@daniel-mendler.de>
>
> > Thanks. Would you like to suggest a patch to fix this?
>
> I don't have a patch ready. Currently I use the following line in my
> configuration which also recognizes Embark keymaps. Would we want to
> list keymaps as a separate Imenu category "Keymaps" or as "Variables"?
I think we want it with "Variables", since its name hints on that.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap are not listed
2022-12-15 14:49 bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap are not listed Daniel Mendler
2022-12-17 12:53 ` Eli Zaretskii
@ 2023-09-06 9:14 ` Stefan Kangas
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2023-09-06 9:14 UTC (permalink / raw)
To: Daniel Mendler; +Cc: 60093
forcemerge 64831 60093
thanks
Daniel Mendler <mail@daniel-mendler.de> writes:
> Keymaps defined via `defvar-keymap' are not available in the Imenu. It is
> necessary to extend `imenu-generic-expression'.
This was fixed in
commit bcadb728e2f46263ca69a4702b70ff2c3bb62deb
Author: Brian Leung <leungbk@posteo.net>
Date: Mon Jul 24 04:32:19 2023 -0700
lisp-mode.el: Add defvar-keymap to lisp-imenu-generic-expression
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-06 9:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 14:49 bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap are not listed Daniel Mendler
2022-12-17 12:53 ` Eli Zaretskii
2022-12-19 9:54 ` Daniel Mendler
2022-12-19 12:46 ` Eli Zaretskii
2023-09-06 9:14 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).