From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>,
"Eli Zaretskii" <eliz@gnu.org>,
jostein@kjonigsen.net, 60376@debbugs.gnu.org
Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features
Date: Sat, 31 Dec 2022 14:21:24 -0800 [thread overview]
Message-ID: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> (raw)
In-Reply-To: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com>
Theodor Thornhill <theo@thornhill.no> writes:
> On 31 December 2022 10:53:54 CET, "Jostein Kjønigsen" <jostein@secure.kjonigsen.net> wrote:
>>On 30.12.2022 20:30, Theodor Thornhill wrote:
>>> Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
>>>
>>>>> On 30 Dec 2022, at 16:46, Eli Zaretskii <eliz@gnu.org> wrote:
>>>>>
>>>>>
>>>>>> Date: Fri, 30 Dec 2022 15:39:20 +0100
>>>>>> Cc: casouri@gmail.com, 60376@debbugs.gnu.org, theo@thornhill.no
>>>>>> From: Jostein Kjønigsen <jostein@secure.kjonigsen.net>
>>>>>>
>>>>>> To be clear: I think csharp-ts-mode works well beyond 85% (it's what I
>>>>>> use as my daily driver), but the syntax-highlighting at level 3 may be
>>>>>> more excessive than some people (like Stefan) prefer.
>>>>>>
>>>>>> If we instead for these "major" changes suggested by Yuan, instead aim
>>>>>> for just moving some "smaller" implementation-detail
>>>>>> (function-invocations and property-highlighting) to level 4, I think we
>>>>>> she be able to get something which is mostly what Stefan would expect
>>>>>> and prefer, and it would be a much smaller change.
>>>>>>
>>>>>> Then we can take a look at those bigger changes (standardized features,
>>>>>> enabling/disabling them individually, as end-users, etc) for Emacs-30.
>>>>>>
>>>>>> I think that's a more realistic plan. Does that sound OK?
>>>>> Yes, it does. And I urge you to submit patches to that effect.
>>>>>
>>>>> Thanks.
>>>> Theo has offered to come up with some patches and I’ll do my best to battle-test them.
>>>>
>>>> Hopefully we can get this done quickly enough to suit your taste ;)
>>>>
>>> Let's start here!
>>>
>>> If you're satisfied, Jostein, report back, then you install, Yuan?
>>>
>>> Then rinse repeat :-)
>>>
>>> Theo
>>
>>I've tested it, and I can't say I see any regressions.
>>
>>Two things though:
>>
>>- Method-invocations are still getting fontified on level 3. I believe Stefan wanted this to be on level 4?
>>
>>- I see we've missed fontification of method-invocations on self-methods (this.DoSomething()) entirely.
>>
>>If we fix the first thing, I guess the second one is also doable? :)
>>
>>--
>>Jostein
>>
>
> Great! Yuan or Eli, will you install? I'll follow up with more stuff later :)
>
> Theo
I applied it, thanks!
Yuan
next prev parent reply other threads:[~2022-12-31 22:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 8:25 bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Yuan Fu
2022-12-29 19:55 ` Yuan Fu
2022-12-29 21:03 ` Jostein Kjønigsen
2022-12-30 8:21 ` Eli Zaretskii
2022-12-29 22:16 ` Yuan Fu
2022-12-30 8:19 ` Eli Zaretskii
2022-12-30 13:35 ` Jostein Kjønigsen
2022-12-30 14:15 ` Eli Zaretskii
2022-12-30 14:39 ` Jostein Kjønigsen
2022-12-30 15:39 ` Eli Zaretskii
2022-12-30 17:35 ` Jostein Kjønigsen
2022-12-30 19:30 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-31 9:53 ` Jostein Kjønigsen
2022-12-31 10:32 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-30 14:40 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-30 15:04 ` Jostein Kjønigsen
2022-12-31 22:21 ` Yuan Fu [this message]
2023-01-01 16:29 ` Jostein Kjønigsen
2023-01-01 17:24 ` Jostein Kjønigsen
2023-01-01 18:14 ` Jostein Kjønigsen
2023-01-01 18:41 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-02 0:12 ` Yuan Fu
2023-01-02 9:59 ` Jostein Kjønigsen
2023-01-03 5:43 ` Jostein Kjønigsen
2023-01-05 21:27 ` Jostein Kjønigsen
2023-01-03 6:51 ` Yuan Fu
2023-01-03 7:20 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-06 5:55 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com \
--to=casouri@gmail.com \
--cc=60376@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jostein@kjonigsen.net \
--cc=jostein@secure.kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).