From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Sat, 31 Dec 2022 14:21:24 -0800 Message-ID: <1893BC1C-4205-4E49-A903-B226F8C0F235@gmail.com> References: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1413"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Eli Zaretskii , jostein@kjonigsen.net, 60376@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 31 23:22:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBkFC-000091-43 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Dec 2022 23:22:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBkEu-0001ew-Mc; Sat, 31 Dec 2022 17:22:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBkEt-0001eo-4s for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 17:22:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBkEs-0004Ic-TB for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 17:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBkEs-0001kV-F8 for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 17:22:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <7A5618C7-25D7-4B52-8D16-5C54F09FA4CA@gmail.com> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2022 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.16725252956688 (code B ref 60376); Sat, 31 Dec 2022 22:22:02 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 31 Dec 2022 22:21:35 +0000 Original-Received: from localhost ([127.0.0.1]:39990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBkEQ-0001jn-KN for submit@debbugs.gnu.org; Sat, 31 Dec 2022 17:21:34 -0500 Original-Received: from mail-pj1-f45.google.com ([209.85.216.45]:44629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBkEO-0001jZ-1j for 60376@debbugs.gnu.org; Sat, 31 Dec 2022 17:21:32 -0500 Original-Received: by mail-pj1-f45.google.com with SMTP id o31-20020a17090a0a2200b00223fedffb30so24802714pjo.3 for <60376@debbugs.gnu.org>; Sat, 31 Dec 2022 14:21:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=Evz/h9NlofHPnl1cXaHIIdgm4okkfDke611SaEt+eGs=; b=Rt2IFMowVr/YMsaQSzLnYVb4An0dQCX6u0tFB+Y+a2rU2lQhVHexvTNT+DkX5O6Whh 5XOoPX/1zuk3Nc3lS3+GfJwuI86/0v2xQFB3ZLcgzHv36frRIoBI1Vp3KLX8rFsPyiN3 CwDkUXqv26Q+EPmEOJLzaqwzgOi5qPwmcAa3+PXzCqlia2epJTSkiOeOvuPS7h10SGou 7Kw31ylh6XXwGaA+pFeQTE/j3NCCvG+YdJJSpXNst4NcPt08pWGAM7h1KV+Beb6elK65 xgBzP8u6RMAp5T6DYC/IPsj7K66TK95WnkNO2sADfvgPbPG6UpMa6eAMgXsakneJus65 NNFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Evz/h9NlofHPnl1cXaHIIdgm4okkfDke611SaEt+eGs=; b=h4gCvl2dRN2CbjNdaJ//cyBZcACsNJOkBqJPVyxBffGbXwNFMuuHZ3v596o4DYli9e laYjdYVUev024aVW3KEMMV0+whwPTNBn1R+4YiE/EVFR6r4SXU66QA8UBuO7EUGU8wnO R6LRJWB/7E/fNRKYch5+LhtrvIR+3n2fm7XO53spMDVVajkypyQ7sSi0NeoUUTcKUf1O YHwt1mKG1CqdYomRGg7w9dNIJSPN5sXfnZqfemuPMwiqfpyYqrAJLhe8rG8DZPnay1NV Jn1ltn1s/DfqH6WD9o/R9KFs/VHOdoHPlD2DMakqfWzQ4x9jz2j62BpEHHVwkC7qrs0/ moGA== X-Gm-Message-State: AFqh2ko//yN0/ESQPVlmt17QavFGELIMkBqD62+HSSPU7V0j1yNAuRti k7wGmFhhgOLMWIzpdl2/M1I= X-Google-Smtp-Source: AMrXdXukRD+aYsgPV7sDXdBxBt0hzTWjc+o9nXYqEpKbw0DcVJKRy64aHI6cN3h/Tqj6Gz07wqbVEQ== X-Received: by 2002:a17:902:7c8a:b0:192:835d:c861 with SMTP id y10-20020a1709027c8a00b00192835dc861mr18942295pll.68.1672525286193; Sat, 31 Dec 2022 14:21:26 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id e7-20020a17090301c700b00177f25f8ab3sm17295459plh.89.2022.12.31.14.21.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Dec 2022 14:21:25 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252219 Archived-At: Theodor Thornhill writes: > On 31 December 2022 10:53:54 CET, "Jostein Kj=C3=B8nigsen" = wrote: >>On 30.12.2022 20:30, Theodor Thornhill wrote: >>> Jostein Kj=C3=B8nigsen writes: >>>=20 >>>>> On 30 Dec 2022, at 16:46, Eli Zaretskii wrote: >>>>>=20 >>>>> =EF=BB=BF >>>>>> Date: Fri, 30 Dec 2022 15:39:20 +0100 >>>>>> Cc: casouri@gmail.com, 60376@debbugs.gnu.org, theo@thornhill.no >>>>>> From: Jostein Kj=C3=B8nigsen >>>>>>=20 >>>>>> To be clear: I think csharp-ts-mode works well beyond 85% (it's = what I >>>>>> use as my daily driver), but the syntax-highlighting at level 3 = may be >>>>>> more excessive than some people (like Stefan) prefer. >>>>>>=20 >>>>>> If we instead for these "major" changes suggested by Yuan, = instead aim >>>>>> for just moving some "smaller" implementation-detail >>>>>> (function-invocations and property-highlighting) to level 4, I = think we >>>>>> she be able to get something which is mostly what Stefan would = expect >>>>>> and prefer, and it would be a much smaller change. >>>>>>=20 >>>>>> Then we can take a look at those bigger changes (standardized = features, >>>>>> enabling/disabling them individually, as end-users, etc) for = Emacs-30. >>>>>>=20 >>>>>> I think that's a more realistic plan. Does that sound OK? >>>>> Yes, it does. And I urge you to submit patches to that effect. >>>>>=20 >>>>> Thanks. >>>> Theo has offered to come up with some patches and I=E2=80=99ll do = my best to battle-test them. >>>>=20 >>>> Hopefully we can get this done quickly enough to suit your taste ;) >>>>=20 >>> Let's start here! >>>=20 >>> If you're satisfied, Jostein, report back, then you install, Yuan? >>>=20 >>> Then rinse repeat :-) >>>=20 >>> Theo >> >>I've tested it, and I can't say I see any regressions. >> >>Two things though: >> >>- Method-invocations are still getting fontified on level 3. I believe = Stefan wanted this to be on level 4? >> >>- I see we've missed fontification of method-invocations on = self-methods (this.DoSomething()) entirely. >> >>If we fix the first thing, I guess the second one is also doable? :) >> >>-- >>Jostein >> > > Great! Yuan or Eli, will you install? I'll follow up with more stuff = later :) > > Theo I applied it, thanks! Yuan