bug#36278: 26.1; ada-mode 6.0.0 auto-casing no longer honors the casing of the declaration

bug#36278: 26.1; ada-mode 6.0.0 auto-casing no longer honors the casing of the declaration

[Ludovic Brenta]

Package: emacs, ada-mode
X-Debbugs-CC: ada-mode-users@nongnu.org
Severity: minor

Hello,

In ada-mode 5.2, auto-casing honors the casing of the declaration of an
entity but ada-mode 6.2 does not; instead it forces the user to create
a casing exception on every declaration that uses "non-standard" casing.
In our large code base this causes frustration as programmers often
introduce local upper-case acronyms to shorten some names, e.g.

procedure A (The_Flight : in Flight.T) is
    FTFX : Flight.Fixed_Info.T renames The_Flight.Fixed_Info;
begin
    FTFX.Foo := True;
end A;

Supposing a procedure A that is hundreds of lines long with dozens of
uses of FTFX, ada-mode 6.0 is unhelpful when forcing the casing down
to Ftfx.  Adding casing exceptions for such local uses is not really
appealing.

Would it be difficult to use casing-as-declaration by default with the
new parser in 6.x?

-- 
Ludovic Brenta.

bug#36278: update

[Stephen Leake]

Can you post a working example showing ada-mode 5.2 respecting the
casing of the declaration? As far as I know, that has never been
supported by ada-mode.

The GNAT compiler casing check does enforce that.

The ada-mode parser does not do name resolution, so it cannot
associate a variable use with a variable declaration, so it is not
possible to implement this.

We could automate declaring the exceptions; the parser can find all
variable declarations in a file, and check to see if they need a casing
exception.

If there are a lot of exceptions that are single-file only, we could
support per-file exceptions, by declaring them in the Emacs Local
Variables.

-- 
-- Stephe

bug#36278: update

[Stephen Leake]

Another solution is to add a user option to not auto-correct all uppercase.
-- 
-- Stephe

bug#36278: update

[Stephen Leake]

In ada-mode version 6.1.1 (released 11 Jul 2019), ada-auto-case can now
take the value `not-upper-case'; typed words that are all upper case are
not adjusted.
-- 
-- Stephe

bug#36278: Fixed in ada-mode 6.1.1

[Stephen Leake]

Fixed in ada-mode 6.1.1; set ada-auto-case to 'not-upper-case.
-- 
-- Stephe

bug#36278: close

[Stephen Leake]

-- 
-- Stephe