unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Peter Oliver <p.d.oliver@mavit.org.uk>
To: 37847@debbugs.gnu.org
Subject: bug#37847: [PATCH] Improve client/daemon xdg/systemd experience
Date: Fri, 28 May 2021 18:21:55 +0100 (BST)	[thread overview]
Message-ID: <147bf9e-b379-ed8e-e142-44f495e598e8@froglet.home.mavit.org.uk> (raw)
In-Reply-To: <CAELgYhfYX+eNrEaiJn0dpLySbW-BcE9E=gyjy7ZgsVoq67kXgg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

In the systemd service, I believe that Carlos was setting $0 to emacsd for the following effect:

$ xprop -name emacsd@$HOST | grep WM_CLASS
WM_CLASS(STRING) = "emacsd", "Emacsd"

This is because desktops use the StartupWMClass in the .desktop file to match which windows are associated with which .desktop file, and we want a daemonised Emacs to be matched to emacsclient.desktop rather than emacs.desktop.

Consequently, now that this section of the patch has been reverted, the following line remaining in emacsclient.desktop makes no sense:

StartupWMClass=Emacsd


Perhaps we can find a different way of setting the WM_CLASS X11 property?

Alternatively, if we merge the two .desktop files, this issue goes away.  There is currently some discussion of doing this for other reasons on emacs-devel.


I’ve unarchived bug 37847 in order to add this comment, and hope that that isn’t a breach of etiquette.  I’ll happily raise a new bug if that’s preferred.

-- 
Peter Oliver

      parent reply	other threads:[~2021-05-28 17:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <MN2PR18MB2765AF5AE45CED817D2D0F86C9290@MN2PR18MB2765.namprd18.prod.outlook.com>
2019-10-21  7:15 ` bug#37847: [PATCH] Improve client/daemon xdg/systemd experience Carlos Pita
2019-10-21  7:27   ` Carlos Pita
2019-10-21 15:37     ` Carlos Pita
2020-08-09 13:59       ` Lars Ingebrigtsen
2020-09-08 21:46   ` Vojtech Stepancik
2020-09-09  9:35     ` Lars Ingebrigtsen
2020-09-09  9:47       ` Vojtech Stepancik
2020-09-09 10:09         ` Lars Ingebrigtsen
2020-10-13  3:48           ` Lars Ingebrigtsen
2021-05-28 17:21   ` Peter Oliver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=147bf9e-b379-ed8e-e142-44f495e598e8@froglet.home.mavit.org.uk \
    --to=p.d.oliver@mavit.org.uk \
    --cc=37847@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).