From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Peter Oliver Newsgroups: gmane.emacs.bugs Subject: bug#37847: [PATCH] Improve client/daemon xdg/systemd experience Date: Fri, 28 May 2021 18:21:55 +0100 (BST) Message-ID: <147bf9e-b379-ed8e-e142-44f495e598e8@froglet.home.mavit.org.uk> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463811583-1844969444-1622222515=:3488" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1758"; mail-complaints-to="usenet@ciao.gmane.io" To: 37847@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 28 19:23:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmgCj-0000GJ-43 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 May 2021 19:23:25 +0200 Original-Received: from localhost ([::1]:44580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmgCh-0006in-U6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 May 2021 13:23:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmgCM-0006ie-TD for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 13:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmgCM-0000Xg-Le for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 13:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmgCM-0000Aq-HZ for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 13:23:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Peter Oliver Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 May 2021 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 37847-submit@debbugs.gnu.org id=B37847.1622222525583 (code B ref 37847); Fri, 28 May 2021 17:23:02 +0000 Original-Received: (at 37847) by debbugs.gnu.org; 28 May 2021 17:22:05 +0000 Original-Received: from localhost ([127.0.0.1]:55286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmgBR-00009L-6J for submit@debbugs.gnu.org; Fri, 28 May 2021 13:22:05 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:44719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmgBP-00008q-0Q for 37847@debbugs.gnu.org; Fri, 28 May 2021 13:22:04 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id r10so3969698wrj.11 for <37847@debbugs.gnu.org>; Fri, 28 May 2021 10:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; h=date:from:to:subject:message-id:mime-version; bh=GXqHeB5Mz9jImmK1rmd0h5pJFNRTPY6+HIXM4ddqCg0=; b=mz9MuaXaL0iRvD7bsFBjOKY25NRfYpOnqdmb4qMbghq3LQ0KIjR2diThi8uKfm4Isc JKAICjVpvhunpTJRkZehklWHHPb3FpuGqJRVzs8RyQ57bqjTjswAA1HacCbaeDYAApLj Y28xgFesaGB6QKHZgeWl/CuAEaCnb9aPqNIIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version; bh=GXqHeB5Mz9jImmK1rmd0h5pJFNRTPY6+HIXM4ddqCg0=; b=XSHengw4HVeiVEGc3k7FHsQyy0Y8D42svgmgGTmVWV0YeHQlVUEA9R2V5dEQnVB5Uh 109t1myRy/27unQNdqDcv5GmLZVBzrH5qX1lXI9KqlsFygZ568h1awif8nYy0dnabflA bo14XiRWqPLRn11atkAlpU6jk1mZH7e4Rd2Jh9rZOshoylV1ale9lGhzn4KL5ZEhdLkv voCMFGI/FlURJt5diyQW0mfu622fmmk/VonWPVZimJ7bNKPT7vnLH0Eli24kLaCF983V ZXQ1x5vWbjClafe+RLgAGbR3Lkd165nwa8cZr20ZUxk9zjgjRKZNv28XbF+RlsByIPCR Xvnw== X-Gm-Message-State: AOAM531YG3sKzSLZ8+Yv5GE4IY+84txUpKoWAEmlrSBMw+ETBfZAHvrA 4ZtaIc+ZC8WXZsFq6x3lItmTvjaMHvl0qA== X-Google-Smtp-Source: ABdhPJyWhsrjEj4W2sgMCGe1rwagJRNp9RWHukoBFVSNDoNaV4z8YXkonMAp/0P0m3kCHHbIhtizCw== X-Received: by 2002:a5d:550e:: with SMTP id b14mr10057417wrv.406.1622222517015; Fri, 28 May 2021 10:21:57 -0700 (PDT) Original-Received: from froglet.home.mavit.org.uk (cpc118948-dudl14-2-0-cust32.16-1.cable.virginm.net. [82.37.201.33]) by smtp.gmail.com with ESMTPSA id u3sm7464817wre.76.2021.05.28.10.21.56 for <37847@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 10:21:56 -0700 (PDT) Original-Received: from froglet.home.mavit.org.uk (localhost [127.0.0.1]) by froglet.home.mavit.org.uk (8.16.1/8.15.2) with ESMTPS id 14SHLtDc034174 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for <37847@debbugs.gnu.org>; Fri, 28 May 2021 18:21:55 +0100 Original-Received: from localhost (mavit@localhost) by froglet.home.mavit.org.uk (8.16.1/8.16.1/Submit) with ESMTP id 14SHLtlS034171 for <37847@debbugs.gnu.org>; Fri, 28 May 2021 18:21:55 +0100 X-Authentication-Warning: froglet.home.mavit.org.uk: mavit owned process doing -bs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207471 Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811583-1844969444-1622222515=:3488 Content-Type: text/plain; format=flowed; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT In the systemd service, I believe that Carlos was setting $0 to emacsd for the following effect: $ xprop -name emacsd@$HOST | grep WM_CLASS WM_CLASS(STRING) = "emacsd", "Emacsd" This is because desktops use the StartupWMClass in the .desktop file to match which windows are associated with which .desktop file, and we want a daemonised Emacs to be matched to emacsclient.desktop rather than emacs.desktop. Consequently, now that this section of the patch has been reverted, the following line remaining in emacsclient.desktop makes no sense: StartupWMClass=Emacsd Perhaps we can find a different way of setting the WM_CLASS X11 property? Alternatively, if we merge the two .desktop files, this issue goes away. There is currently some discussion of doing this for other reasons on emacs-devel. IĒve unarchived bug 37847 in order to add this comment, and hope that that isnĒt a breach of etiquette. IĒll happily raise a new bug if thatĒs preferred. -- Peter Oliver ---1463811583-1844969444-1622222515=:3488--