unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#20451: 25.0.50; [PATCH] Add prefix argument to `pwd'
@ 2015-04-28 19:50 Simen Heggestøyl
  2015-04-30 22:37 ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Simen Heggestøyl @ 2015-04-28 19:50 UTC (permalink / raw)
  To: 20451

[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]

I often find myself doing `C-u M-x pwd RET', hoping that the current
default directory will be inserted at point, but it doesn't. `pwd'
doesn't currently act on a prefix argument, so why not let it do this?

This matches how `shell-command', and newly also `quick-calc', treat
prefix arguments.


 From 56c93aa20b19bebb5cb1afcf3894911355d23e30 Mon Sep 17 00:00:00 2001
 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@gmail.com>
Date: Tue, 28 Apr 2015 21:25:20 +0200
Subject: [PATCH] * lisp/files.el (pwd):

When called with a prefix argument, insert the current default
directory at point.
---
 etc/NEWS      |  3 +++
 lisp/files.el | 12 ++++++++----
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 5046d30..7497652 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -817,6 +817,9 @@ name.  The variable `system-name' is now obsolete.
 +++
 ** Function `write-region' no longer outputs "Wrote FILE" in batch 
mode.

+** If `pwd' is called with a prefix argument, insert the current 
default
+directory at point.
+
 ---
 ** New utilities in subr-x.el:
 *** New macros `if-let' and `when-let' allow defining bindings and to
diff --git a/lisp/files.el b/lisp/files.el
index 045eeaf..ef6ac7b 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -654,10 +654,14 @@ the value of `default-directory'."
 		  'file-directory-p))


-(defun pwd ()
-  "Show the current default directory."
-  (interactive nil)
-  (message "Directory %s" default-directory))
+(defun pwd (&optional insert)
+  "Show the current default directory.
+With prefix argument INSERT, insert the current default directory
+at point instead."
+  (interactive "P")
+  (if insert
+      (insert default-directory)
+    (message "Directory %s" default-directory)))

 (defvar cd-path nil
   "Value of the CDPATH environment variable, as a list.
-- 
2.1.4

[-- Attachment #2: Type: text/html, Size: 2708 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#20451: 25.0.50; [PATCH] Add prefix argument to `pwd'
  2015-04-28 19:50 bug#20451: 25.0.50; [PATCH] Add prefix argument to `pwd' Simen Heggestøyl
@ 2015-04-30 22:37 ` Stefan Monnier
  2015-05-01 21:28   ` Simen Heggestøyl
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-04-30 22:37 UTC (permalink / raw)
  To: Simen Heggestøyl; +Cc: 20451

> I often find myself doing `C-u M-x pwd RET', hoping that the current
> default directory will be inserted at point, but it doesn't. `pwd'
> doesn't currently act on a prefix argument, so why not let it do this?
> This matches how `shell-command', and newly also `quick-calc', treat
> prefix arguments.

Looks OK, thank you,


        Stefan





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#20451: 25.0.50; [PATCH] Add prefix argument to `pwd'
  2015-04-30 22:37 ` Stefan Monnier
@ 2015-05-01 21:28   ` Simen Heggestøyl
  0 siblings, 0 replies; 3+ messages in thread
From: Simen Heggestøyl @ 2015-05-01 21:28 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 20451-done

[-- Attachment #1: Type: text/plain, Size: 133 bytes --]

On Fri, May 1, 2015 at 12:37 AM, Stefan Monnier 
<monnier@iro.umontreal.ca> wrote:
> Looks OK, thank you,

Thanks, landed.

-- Simen

[-- Attachment #2: Type: text/html, Size: 272 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-01 21:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-28 19:50 bug#20451: 25.0.50; [PATCH] Add prefix argument to `pwd' Simen Heggestøyl
2015-04-30 22:37 ` Stefan Monnier
2015-05-01 21:28   ` Simen Heggestøyl

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).