unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: pillule <pillule@riseup.net>, 48367@debbugs.gnu.org
Subject: bug#48367: 28.0.50; quit-restore-buffer may jam
Date: Wed, 12 May 2021 10:47:55 +0200	[thread overview]
Message-ID: <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> (raw)
In-Reply-To: <87h7j9xbj3.fsf@host.localdomain>

 > The first patch adress this, and a similar one : when there is a previous-buffer available, but it referes to the same buffer. (eg: try the recipe again but exchange the role of *Messages* and *Backtrace*, you will finish with a blank buffer for backtrace, that you can quit again to end up to the same point)
 >
 > The second patch is a proposition to clarify a little the code.

LGTM.  Can you please provide a ChangeLog entry and add a short comment
in the code that mentions the bug number of your report.

Also, have you signed the copyright agreement for Emacs?  How should I
call you in the commit?  "pillule"?

And please try to avoid putting your local settings in diffs as with

--- /usr/share/emacs/28.0.50/lisp/window.el.gz
+++ /home/user/src/patches/window.el

Many thanks, martin





  reply	other threads:[~2021-05-12  8:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 20:26 bug#48367: 28.0.50; quit-restore-buffer may jam pillule
2021-05-12  8:47 ` martin rudalics [this message]
2021-05-12 11:25   ` bug#48367: 28.0.50; quit-restore-window " pillule
2021-05-12 12:32     ` martin rudalics
2021-05-12 14:10       ` pillule
2021-05-12 16:40         ` martin rudalics
2021-05-15  8:56         ` martin rudalics
2021-05-15 10:34           ` pillule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at \
    --to=rudalics@gmx.at \
    --cc=48367@debbugs.gnu.org \
    --cc=pillule@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).