From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#48367: 28.0.50; quit-restore-buffer may jam Date: Wed, 12 May 2021 10:47:55 +0200 Message-ID: <13f5a988-f78b-11ed-fcde-fc03ad841390@gmx.at> References: <87h7j9xbj3.fsf@host.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11588"; mail-complaints-to="usenet@ciao.gmane.io" To: pillule , 48367@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 12 10:50:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgkZT-0002rZ-3W for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 May 2021 10:50:23 +0200 Original-Received: from localhost ([::1]:47062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgkZS-0000eV-5v for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 May 2021 04:50:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgkYA-00088O-CP for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 04:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgkYA-00070B-4Q for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 04:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgkYA-0001ei-35 for bug-gnu-emacs@gnu.org; Wed, 12 May 2021 04:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 May 2021 08:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48367 X-GNU-PR-Package: emacs Original-Received: via spool by 48367-submit@debbugs.gnu.org id=B48367.16208092876279 (code B ref 48367); Wed, 12 May 2021 08:49:02 +0000 Original-Received: (at 48367) by debbugs.gnu.org; 12 May 2021 08:48:07 +0000 Original-Received: from localhost ([127.0.0.1]:38145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgkXH-0001dD-BJ for submit@debbugs.gnu.org; Wed, 12 May 2021 04:48:07 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:35817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgkXF-0001cU-DB for 48367@debbugs.gnu.org; Wed, 12 May 2021 04:48:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620809276; bh=kWIeFslQk4MQwvHofcoH97IVlfWBf7A/tC3JN7ilrk8=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=HJ9q8kzs4kRTCtXrEEjwIDtvoqwwpd2/Vc0CH7H30nP3iERq7g51LW7kaMPkt4+Vy pFYNGgxy4H0HE1LmMCVaguWFHqMobHn/HNHVNlXVyuauo7aE/AZnVDW95vgiLLseoh 9Re8ZuJ7pwfeilUQ86O4wgHr+i2i/hbE9JDYLdUE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([46.125.249.51]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mg6Zw-1l1Lla23m2-00haPg; Wed, 12 May 2021 10:47:56 +0200 In-Reply-To: <87h7j9xbj3.fsf@host.localdomain> Content-Language: en-US X-Provags-ID: V03:K1:DKeBM/CCCodAs24017563KQPpJfChz3fj6YQtI0Ovc+JIaZ6F+B mi15tU8Chyk08Y9li5kLQGcSd1cE/X2twIXRVYMKVOY6uLa/iyQPxUYTqyaloraJJuUZ/gD QnUpHtPgEGcfae6Bxx1z3dHr/FB9YwOuiVhyvyDMm5iVWZutBpOcDg0eOSgdVFmWz41XjXF svieBr+4mJ4HCn2f4hS1Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:ln2JRtm8bAw=:HQrHufTNI+BFYJ50rIVieo kDMDo5IY0rXC/uBiD2OZB2s9XAu8m+ifBLwd7u48fJ1hZQ/QIbwc9W2Xe/pwdENUtDllBFmNs CUxIDYY49o9/jZYfhOXAZ0V8ntmAbHJ85i5NMZH4MTZcqOBBHnmLrZynryi3ZC72kbvKdk255 Gh0bgIdfqnkdTQ1FfY60fLxO3eROtYCn5w2KVeg+N4VKCT/9In+CTR+z/GSf2iFC/uvGp6dP7 Kl3qLvzHlyDz8s7VKPIPlRmfy9TBht3Bycv1oN3KHCUFL7ClpLr2cGEJXgKL/6kLUyIzbCpek eTpZjGKoXb9vEl/tPjaBLquriE9HTQjV3ZXbv35Fo1xFjVXCVvSuobEnmCCnFv9U9M5bkijho IdvxH2zLhYK+D5mb8N/5sUgwOb6zuiIJLZLB7xL6QfdIrVaRRFM/N6M340xnLC13jh6weFNAu 6IVxFXAj0DrXTgn0k7lvjyZTdMT1Q2LxVExYqYZeAJ3XJ+vWuXImOmcmeCEaSm9hkR/ReyaDu qaXajgv0ntx45+bV0qTPyTGm5GRWybkXC2nyIv8bTg9CCFKkDJ+mgLGNANnM8e6RlecKTr2pi 5U7SttlmbN6kR47yuHfd6JVGuScBq21+kVH2iqa9IjEkdDR3+mYL1di7HzryYFdmQrysNA240 lvGZab4ggmc2FUJ+PC6pUQJLiXFTa61xXr+QYtovG/6qCrC6TrMGfK1y402ebUvielojOLMEe 6vylsdG4LjYoO3RUvM0xjZQU32eAnzYQsQyTb2QsZGakmR8e16bCmSf09o9W+PDJ6yYt1xy0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206306 Archived-At: > The first patch adress this, and a similar one : when there is a previous-buffer available, but it referes to the same buffer. (eg: try the recipe again but exchange the role of *Messages* and *Backtrace*, you will finish with a blank buffer for backtrace, that you can quit again to end up to the same point) > > The second patch is a proposition to clarify a little the code. LGTM. Can you please provide a ChangeLog entry and add a short comment in the code that mentions the bug number of your report. Also, have you signed the copyright agreement for Emacs? How should I call you in the commit? "pillule"? And please try to avoid putting your local settings in diffs as with --- /usr/share/emacs/28.0.50/lisp/window.el.gz +++ /home/user/src/patches/window.el Many thanks, martin