unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 13141@debbugs.gnu.org
Subject: bug#13141: 24.3.50; Be able to customize the info included by default for`report-emacs-bug'
Date: Sun, 20 Jan 2013 17:35:31 -0800	[thread overview]
Message-ID: <13B0960231D241BD863EBF027D5C3A46@us.oracle.com> (raw)
In-Reply-To: <jwvd2wz8h4s.fsf-monnier+emacs@gnu.org>

> > That change unfortunately breaks fitting the frame to the 
> > buffer (using my fit-frame.el), horribly.
> 
> I'd rather fix fit-frame.el so it handles this case as well.

Suggestions welcome. ;-)

I've thought a little about it.  I could check each character for a display
property that is, in effect, a replacement string (as in this case), and then
get its width.

But that would slow things down considerably.  Currently I just get the line
width for each line using `end-of-line'.

I believe there is a longstanding Emacs bug regarding the same kind of thing for
a vanilla Emacs function that does some window/buffer fitting.

Perhaps you recall the discussion from a few years back.  The plan/hope was to
make it DTRT in terms of what actually gets displayed, not just what is inserted
(text, images) in the buffer.  AFAIK, nothing ever came of those hopes.
fit-frame.el suffers from the same lack of magic.

Anyway, clearly, for this latest bug (breaking fit-frame), it is FAR easier to
revert to what we had before your fix or to find some other solution to the
problem, as you saw it, of users copying text they "shouldn't".

It is far easier to fix that than it would be to fix fit-frame.el's calculation
of needed frame size so that it takes all display artifacts into account.

We should not let the ideal become the enemy of the good.  But as I said, if you
have some simple suggestions for fit-frame.el in this regard, they are welcome.

Even then, while waiting, it would be good to fix this minor
unwarranted-text-copying problem some other way than your `display' property
hack.  I don't even see it as a real problem that needed fixing, personally, or
at least not an important one.  How much has it really been a problem in
practice that users included instructions in their bug-report text?






  reply	other threads:[~2013-01-21  1:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 16:00 bug#13141: 24.3.50; Be able to customize the info included by default for `report-emacs-bug' Drew Adams
2012-12-11 16:12 ` Dani Moncayo
2012-12-11 16:18   ` Drew Adams
2012-12-11 16:24     ` Dani Moncayo
2012-12-11 16:28       ` Drew Adams
2012-12-11 19:13   ` Jambunathan K
2012-12-11 19:19     ` Glenn Morris
2012-12-11 19:34       ` Stefan Monnier
2013-01-20  9:45         ` bug#13141: 24.3.50; Be able to customize the info included by default for`report-emacs-bug' Drew Adams
2013-01-21  1:22           ` Stefan Monnier
2013-01-21  1:35             ` Drew Adams [this message]
2013-01-21  1:54               ` Stefan Monnier
2013-01-21  2:09                 ` Drew Adams
2012-12-11 19:27     ` bug#13141: 24.3.50; Be able to customize the info included by default for `report-emacs-bug' Drew Adams
2012-12-11 16:29 ` Stefan Monnier
2012-12-11 16:37   ` Drew Adams
2012-12-11 19:45 ` Glenn Morris
2012-12-11 19:59   ` bug#13141: [PATCH]: bug#13141: 24.3.50; Be able to customize the info included by default for`report-emacs-bug' Drew Adams
2013-01-19 23:10 ` bug#13141: please review bug #13141 Drew Adams
2013-01-20  0:35   ` Dmitry Gutov
     [not found]   ` <87ip6sofn7.fsf@yandex.ru>
2013-01-20  0:54     ` Xue Fuqiao
2013-01-20  1:03     ` Drew Adams
     [not found]     ` <20130120085455.93b0f44394a4db0ffcebd5c9@gmail.com>
2013-01-20  7:19       ` Stephen J. Turnbull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13B0960231D241BD863EBF027D5C3A46@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=13141@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).