From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#13141: 24.3.50; Be able to customize the info included by default for`report-emacs-bug' Date: Sun, 20 Jan 2013 17:35:31 -0800 Message-ID: <13B0960231D241BD863EBF027D5C3A46@us.oracle.com> References: <8738zc8krw.fsf@gmail.com> <82mwxkjt1g.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1358732168 16976 80.91.229.3 (21 Jan 2013 01:36:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Jan 2013 01:36:08 +0000 (UTC) Cc: 13141@debbugs.gnu.org To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 21 02:36:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tx6JF-0000G0-TV for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Jan 2013 02:36:26 +0100 Original-Received: from localhost ([::1]:51799 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tx6Iy-0004CZ-MZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Jan 2013 20:36:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tx6It-0004CG-Pf for bug-gnu-emacs@gnu.org; Sun, 20 Jan 2013 20:36:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tx6Ir-0007Oo-An for bug-gnu-emacs@gnu.org; Sun, 20 Jan 2013 20:36:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tx6Ir-0007Ok-7O for bug-gnu-emacs@gnu.org; Sun, 20 Jan 2013 20:36:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tx6Jp-0001IW-Qf for bug-gnu-emacs@gnu.org; Sun, 20 Jan 2013 20:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Jan 2013 01:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 13141-submit@debbugs.gnu.org id=B13141.13587322084958 (code B ref 13141); Mon, 21 Jan 2013 01:37:01 +0000 Original-Received: (at 13141) by debbugs.gnu.org; 21 Jan 2013 01:36:48 +0000 Original-Received: from localhost ([127.0.0.1]:42066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tx6Jb-0001Hs-OB for submit@debbugs.gnu.org; Sun, 20 Jan 2013 20:36:48 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:28183) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tx6JZ-0001Hh-8Q for 13141@debbugs.gnu.org; Sun, 20 Jan 2013 20:36:46 -0500 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id r0L1Zgmc019928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 21 Jan 2013 01:35:43 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r0L1Zf3R027591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 21 Jan 2013 01:35:42 GMT Original-Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r0L1ZfOi003497; Sun, 20 Jan 2013 19:35:41 -0600 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 20 Jan 2013 17:35:41 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac33ddf0ZrnYBsbtTg2w9pUiXe2MrAAACnsA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70112 Archived-At: > > That change unfortunately breaks fitting the frame to the > > buffer (using my fit-frame.el), horribly. > > I'd rather fix fit-frame.el so it handles this case as well. Suggestions welcome. ;-) I've thought a little about it. I could check each character for a display property that is, in effect, a replacement string (as in this case), and then get its width. But that would slow things down considerably. Currently I just get the line width for each line using `end-of-line'. I believe there is a longstanding Emacs bug regarding the same kind of thing for a vanilla Emacs function that does some window/buffer fitting. Perhaps you recall the discussion from a few years back. The plan/hope was to make it DTRT in terms of what actually gets displayed, not just what is inserted (text, images) in the buffer. AFAIK, nothing ever came of those hopes. fit-frame.el suffers from the same lack of magic. Anyway, clearly, for this latest bug (breaking fit-frame), it is FAR easier to revert to what we had before your fix or to find some other solution to the problem, as you saw it, of users copying text they "shouldn't". It is far easier to fix that than it would be to fix fit-frame.el's calculation of needed frame size so that it takes all display artifacts into account. We should not let the ideal become the enemy of the good. But as I said, if you have some simple suggestions for fit-frame.el in this regard, they are welcome. Even then, while waiting, it would be good to fix this minor unwarranted-text-copying problem some other way than your `display' property hack. I don't even see it as a real problem that needed fixing, personally, or at least not an important one. How much has it really been a problem in practice that users included instructions in their bug-report text?