From: Dmitry Gutov <dgutov@yandex.ru>
To: Ackerley Tng <ackerleytng@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 59381@debbugs.gnu.org, juri@linkov.net
Subject: bug#59381: Should xref--marker-ring be per-window?
Date: Fri, 25 Nov 2022 01:59:53 +0200 [thread overview]
Message-ID: <0bd4b2db-15cd-62e7-54f7-3eb26627e808@yandex.ru> (raw)
In-Reply-To: <CANZnma79oc5HLRJJdHGN7QMR7s5edAW9eaPPYH87JOFZj-ju+g@mail.gmail.com>
On 25/11/22 01:42, Ackerley Tng wrote:
>> (defcustom xref-history-storage 'xref-window-local-history
> Here's an updated patch!
Nice. :-) Seems good to go.
How would you like to sign the copyright assignment papers for Emacs?
Regarding the patch, I was a tad surprised that there is no use for the
"setter" function of xref-history-store, but it makes sense given that
the value cons serves as a pointer to the data structure which we modify
in-place.
Perhaps we should keep the setter option in the signature anyway, for
someone to be able to reset the history. Or save and restore it. Hm.
next prev parent reply other threads:[~2022-11-24 23:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 5:29 bug#59381: Should xref--marker-ring be per-window? Ackerley Tng
2022-11-19 18:53 ` Juri Linkov
2022-11-19 19:53 ` Eli Zaretskii
2022-11-19 22:01 ` Ackerley Tng
2022-11-20 7:09 ` Eli Zaretskii
2022-11-20 17:00 ` Dmitry Gutov
2022-11-20 17:32 ` Eli Zaretskii
2022-11-20 18:11 ` Ackerley Tng
2022-11-20 18:22 ` Eli Zaretskii
2022-11-20 23:01 ` Dmitry Gutov
2022-11-21 7:42 ` Juri Linkov
2022-11-24 3:16 ` Dmitry Gutov
2022-11-20 2:52 ` Dmitry Gutov
2022-11-20 7:59 ` Eli Zaretskii
2022-11-20 23:17 ` Dmitry Gutov
2022-11-21 13:14 ` Eli Zaretskii
2022-11-22 2:46 ` Ackerley Tng
2022-11-24 3:28 ` Dmitry Gutov
2022-11-24 14:17 ` Dmitry Gutov
2022-11-24 23:42 ` Ackerley Tng
2022-11-24 23:59 ` Dmitry Gutov [this message]
2022-11-25 0:28 ` Ackerley Tng
2022-11-25 1:02 ` Dmitry Gutov
2022-11-24 3:19 ` Dmitry Gutov
2022-11-24 7:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bd4b2db-15cd-62e7-54f7-3eb26627e808@yandex.ru \
--to=dgutov@yandex.ru \
--cc=59381@debbugs.gnu.org \
--cc=ackerleytng@gmail.com \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).