From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59381: Should xref--marker-ring be per-window? Date: Fri, 25 Nov 2022 01:59:53 +0200 Message-ID: <0bd4b2db-15cd-62e7-54f7-3eb26627e808@yandex.ru> References: <86leo6ai85.fsf@mail.linkov.net> <83leo67mbt.fsf@gnu.org> <83v8na5a5e.fsf@gnu.org> <838rk44fgg.fsf@gnu.org> <90fccc99-14e1-80f7-5179-62c44c1833b8@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10887"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: Eli Zaretskii , 59381@debbugs.gnu.org, juri@linkov.net To: Ackerley Tng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 01:01:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyM9i-0002hP-Tc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 01:01:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyM9T-0006hx-JO; Thu, 24 Nov 2022 19:01:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyM9P-0006gl-Sx for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 19:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyM9P-0004AV-9A for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 19:01:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyM9O-0005uW-3I for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 19:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 00:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59381 X-GNU-PR-Package: emacs Original-Received: via spool by 59381-submit@debbugs.gnu.org id=B59381.166933440322577 (code B ref 59381); Fri, 25 Nov 2022 00:01:02 +0000 Original-Received: (at 59381) by debbugs.gnu.org; 25 Nov 2022 00:00:03 +0000 Original-Received: from localhost ([127.0.0.1]:60550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyM8R-0005s5-AV for submit@debbugs.gnu.org; Thu, 24 Nov 2022 19:00:03 -0500 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:39842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyM8P-0005r4-Cz for 59381@debbugs.gnu.org; Thu, 24 Nov 2022 19:00:01 -0500 Original-Received: by mail-wr1-f44.google.com with SMTP id x17so4556550wrn.6 for <59381@debbugs.gnu.org>; Thu, 24 Nov 2022 16:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=4r6dpAhyaYhUkXI7ACtI4asr+7+HotSjCHENfSGphQw=; b=OtpN01DqmCJZK7CScu3d5jZDz9qivzlqgHEQDTknMSA/fc7DfaQZk7t/pj3e04+H0e 9DdSnfAF4oUjiJv3Dm+47/TwJneTzlhMl4geL37NdoOYI635QBNh9gMKS2wypAONXsvz 3Ku97R746gcwoio+h+Qon+UX9NdFMWprODNS04q7Iv56GdBdlHMfZNyZmpV967LQsSeG T+uZG5Z5y0LSgBIPVEok5nV/GM/+ST7QE1znVd/3OVJV/0MC1CkHarmle18g00npYb2A E45t/elK/0T/V7GcE0zOoK3ACh/MWuu/uqp2shvw+tvQdOm0j5qLBUZsTn0AvkSoOlaa phag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4r6dpAhyaYhUkXI7ACtI4asr+7+HotSjCHENfSGphQw=; b=KUrgZx+SAwBe0QfQHRIRTkQ0w+HNArZ0TikK1sTIbdNsapRGOhWjnTpaiqX3EhvR/2 IIDKwWfowwCavUEkeCAFNJL7gweMVn7yMnOezbwUUu61R3JJMLM4uuhSHTo28HGWgFcu Gc7DwIUXYz8XYA/GRtJiNp7mEhTu34iTzw63laWhwlX/qREnD5v4T/BQ1V+gRmSfMZBg 7gU9x+r0RkjWyttKcge02bL3vMkWrNpJ+lr8VfAFaMtON9QloPKNn23JAl2ewLc83+IU d2x1J3RzivaQmZF00dxu5NAhZFDO/GV5B/EbEZd0VUtfw/VUtuQLPfP7h2ps3EFPbBd4 9aqA== X-Gm-Message-State: ANoB5plsdhdt1iAfiN1tqN3ttANZjqtIgwe5SjIK7r8CAF3nOfPAJQEd /hDYkFLqfgw6Bmn0XJNpqpI= X-Google-Smtp-Source: AA0mqf5vhUaKMzrJOTRljGpfqFQTop11syJq23uQafAbsQ0PH6LRoh7OTbTbLp+523JNDCZJYGnPOw== X-Received: by 2002:adf:f74d:0:b0:236:4e3c:7720 with SMTP id z13-20020adff74d000000b002364e3c7720mr21689592wrp.674.1669334395599; Thu, 24 Nov 2022 15:59:55 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id d8-20020a5d6dc8000000b002415dd45320sm2358023wrz.112.2022.11.24.15.59.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Nov 2022 15:59:54 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248932 Archived-At: On 25/11/22 01:42, Ackerley Tng wrote: >> (defcustom xref-history-storage 'xref-window-local-history > Here's an updated patch! Nice. :-) Seems good to go. How would you like to sign the copyright assignment papers for Emacs? Regarding the patch, I was a tad surprised that there is no use for the "setter" function of xref-history-store, but it makes sense given that the value cons serves as a pointer to the data structure which we modify in-place. Perhaps we should keep the setter option in the signature anyway, for someone to be able to reset the history. Or save and restore it. Hm.