* bug#65821: 30.0.50; ielm-indirect-setup-hook boolean type instead of hook type
@ 2023-09-08 11:31 Mauro Aranda
2023-09-08 11:36 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Mauro Aranda @ 2023-09-08 11:31 UTC (permalink / raw)
To: 65821
The option ielm-indirect-setup-hook is supposed to be a hook. However,
its type says it's a boolean.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#65821: 30.0.50; ielm-indirect-setup-hook boolean type instead of hook type
2023-09-08 11:31 bug#65821: 30.0.50; ielm-indirect-setup-hook boolean type instead of hook type Mauro Aranda
@ 2023-09-08 11:36 ` Stefan Kangas
2023-09-08 15:47 ` Mauro Aranda
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2023-09-08 11:36 UTC (permalink / raw)
To: Mauro Aranda, 65821
Mauro Aranda <maurooaranda@gmail.com> writes:
> The option ielm-indirect-setup-hook is supposed to be a hook. However,
> its type says it's a boolean.
Thanks. Would you like to send a patch?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#65821: 30.0.50; ielm-indirect-setup-hook boolean type instead of hook type
2023-09-08 11:36 ` Stefan Kangas
@ 2023-09-08 15:47 ` Mauro Aranda
2023-09-08 16:44 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Mauro Aranda @ 2023-09-08 15:47 UTC (permalink / raw)
To: Stefan Kangas, 65821
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On 8/9/23 08:36, Stefan Kangas wrote:
> Mauro Aranda <maurooaranda@gmail.com> writes:
>
>> The option ielm-indirect-setup-hook is supposed to be a hook. However,
>> its type says it's a boolean.
>
> Thanks. Would you like to send a patch?
Sure. I also removed the :safe property, since it seems to me that it
was just a copy-paste from the other defcustom introduced in the same
commit.
[-- Attachment #2: 0001-Fix-defcustom-type-in-ielm.el.patch --]
[-- Type: text/x-patch, Size: 852 bytes --]
From 4b5b1c3b0b765f6e43ba96427aff03fff74acc64 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Fri, 8 Sep 2023 12:44:42 -0300
Subject: [PATCH] ; Fix defcustom type in ielm.el
* lisp/ielm.el (ielm-indirect-setup-hook): Fix :type and remove :safe
property, since it was probably a copy-pasta. (Bug#65821)
---
lisp/ielm.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/ielm.el b/lisp/ielm.el
index f7d025b8c01..e51c46054b4 100644
--- a/lisp/ielm.el
+++ b/lisp/ielm.el
@@ -491,8 +491,7 @@ ielm-indirect-setup-hook
indirect buffer as the current buffer after its setup is done.
This can be used to further customize fontification and other
behavior of the indirect buffer."
- :type 'boolean
- :safe 'booleanp
+ :type 'hook
:version "29.1")
(defun ielm-indirect-setup-hook ()
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#65821: 30.0.50; ielm-indirect-setup-hook boolean type instead of hook type
2023-09-08 15:47 ` Mauro Aranda
@ 2023-09-08 16:44 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2023-09-08 16:44 UTC (permalink / raw)
To: Mauro Aranda, 65821-done
Version: 29.2
Mauro Aranda <maurooaranda@gmail.com> writes:
> On 8/9/23 08:36, Stefan Kangas wrote:
> > Mauro Aranda <maurooaranda@gmail.com> writes:
> >
> >> The option ielm-indirect-setup-hook is supposed to be a hook. However,
> >> its type says it's a boolean.
> >
> > Thanks. Would you like to send a patch?
>
> Sure. I also removed the :safe property, since it seems to me that it
> was just a copy-paste from the other defcustom introduced in the same
> commit.
Thank you, installed on emacs-29.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-08 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-08 11:31 bug#65821: 30.0.50; ielm-indirect-setup-hook boolean type instead of hook type Mauro Aranda
2023-09-08 11:36 ` Stefan Kangas
2023-09-08 15:47 ` Mauro Aranda
2023-09-08 16:44 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).