* bug#13510: 24.3.50; `report-emacs-bug' binds `C-c m', which is reserved for users
@ 2013-01-20 22:56 Drew Adams
2013-02-09 4:41 ` Chong Yidong
0 siblings, 1 reply; 3+ messages in thread
From: Drew Adams @ 2013-01-20 22:56 UTC (permalink / raw)
To: 13510
This code in `report-emacs-bug' violates the convention set forth in
(elisp) `Key Binding Conventions', which reserves `C-c' plus a
letter for users:
(define-key (current-local-map) "\C-cm"
'report-emacs-bug-insert-to-mailer)
Hard to believe this happened. New key bindings, especially in longstanding,
core Emacs modes, should be reviewed before a
release. The bug was introduced in Emacs 24.1.
The doc is unequivocal about this:
Don't define `C-c LETTER' as a key in Lisp programs. Sequences
consisting of `C-c' and a letter (either upper or lower case) are
reserved for users; they are the *only* sequences reserved for
users, so do not block them.
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
of 2013-01-18 on ODIEONE
Bzr revision: 111548 sdl.web@gmail.com-20130118182218-6ywd47qsbnow6nsg
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
`configure --with-gcc (4.7) --no-opt --enable-checking --cflags
-IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#13510: 24.3.50; `report-emacs-bug' binds `C-c m', which is reserved for users
2013-01-20 22:56 bug#13510: 24.3.50; `report-emacs-bug' binds `C-c m', which is reserved for users Drew Adams
@ 2013-02-09 4:41 ` Chong Yidong
2013-02-09 16:16 ` Drew Adams
0 siblings, 1 reply; 3+ messages in thread
From: Chong Yidong @ 2013-02-09 4:41 UTC (permalink / raw)
To: Drew Adams; +Cc: 13510-done
"Drew Adams" <drew.adams@oracle.com> writes:
> This code in `report-emacs-bug' violates the convention set forth in
> (elisp) `Key Binding Conventions', which reserves `C-c' plus a
> letter for users:
>
> (define-key (current-local-map) "\C-cm"
> 'report-emacs-bug-insert-to-mailer)
This is indeed a mistake. Since this bug was introduced in Emacs 24.1,
it is a regression against Emacs 23; I went ahead and fixed it in the
emacs-24 branch, with the new binding C-c M-i.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#13510: 24.3.50; `report-emacs-bug' binds `C-c m', which is reserved for users
2013-02-09 4:41 ` Chong Yidong
@ 2013-02-09 16:16 ` Drew Adams
0 siblings, 0 replies; 3+ messages in thread
From: Drew Adams @ 2013-02-09 16:16 UTC (permalink / raw)
To: 'Chong Yidong'; +Cc: 13510-done
> > This code in `report-emacs-bug' violates the convention set forth in
> > (elisp) `Key Binding Conventions', which reserves `C-c' plus a
> > letter for users:
> >
> > (define-key (current-local-map) "\C-cm"
> > 'report-emacs-bug-insert-to-mailer)
>
> This is indeed a mistake. Since this bug was introduced in
> Emacs 24.1, it is a regression against Emacs 23; I went ahead
> and fixed it in the emacs-24 branch, with the new binding C-c M-i.
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-09 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-20 22:56 bug#13510: 24.3.50; `report-emacs-bug' binds `C-c m', which is reserved for users Drew Adams
2013-02-09 4:41 ` Chong Yidong
2013-02-09 16:16 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).