unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Hansen <rhansen@rhansen.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 56210@debbugs.gnu.org, larsi@gnus.org
Subject: bug#56210: 29.0.50; Keyboard macros do not trigger after-change-functions
Date: Mon, 27 Jun 2022 13:23:28 -0400	[thread overview]
Message-ID: <08eb5638-4cc7-20f0-b717-a59fba5cd213@rhansen.org> (raw)
In-Reply-To: <327ead91-4b3f-6177-b3a1-4f1db57c3e85@rhansen.org>


[-- Attachment #1.1: Type: text/plain, Size: 702 bytes --]

On 6/27/22 13:07, Richard Hansen wrote:
> On 6/27/22 12:54, Eli Zaretskii wrote:
>> Your test calls with-current-buffer-window, which calls 
>> temp-buffer-window-setup, which inhibits modification hooks:
> 
> Yup, that's it!  If I set `inhibit-modification-hooks' back to nil 
> then it works.  Thank you.

However, that doesn't explain why the original test code fails.  If you add a `(should (null inhibit-modification-hooks))` just before the call to `execute-kbd-macro' it will not fail there.

But that original test code is incorrect anyway (the selected window is not explicitly switched to the temporary buffer before running the keyboard macro), so it doesn't really matter to me.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2022-06-27 17:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-25  6:21 bug#56210: 29.0.50; Keyboard macros do not trigger after-change-functions Richard Hansen
2022-06-25 11:51 ` Lars Ingebrigtsen
2022-06-25 18:06   ` Richard Hansen
2022-06-25 18:56     ` Eli Zaretskii
2022-06-25 20:34       ` Richard Hansen
2022-06-26  8:10         ` Eli Zaretskii
2022-06-27  3:21           ` Richard Hansen
2022-06-27  7:50             ` Lars Ingebrigtsen
2022-06-27 16:52               ` Richard Hansen
2022-06-27 16:54             ` Eli Zaretskii
2022-06-27 17:07               ` Richard Hansen
2022-06-27 17:17                 ` Eli Zaretskii
2022-06-27 17:22                   ` Richard Hansen
2022-06-28 11:31                   ` Lars Ingebrigtsen
2022-06-28 12:20                     ` Eli Zaretskii
2022-06-28 12:26                       ` Lars Ingebrigtsen
2022-06-27 17:23                 ` Richard Hansen [this message]
2022-06-29 23:17               ` Richard Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08eb5638-4cc7-20f0-b717-a59fba5cd213@rhansen.org \
    --to=rhansen@rhansen.org \
    --cc=56210@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).